[WOOMOB-1341] Booking details fragment skeleton #14620

AdamGrzybkowski · 2025-09-16T16:13:37Z

Description

This is a basic skeleton Fragment with a compose screen and a ViewModel for the Booking Details screen.
I've looked into the existing patterns to avoid introducing new ones.

For now, I've added an extra row to the "Developer options" to open the Booking details screen with a fixed ID. Not sure if that's the best place, but this seemed like a good fit to make sure it's only available in debug builds.
I guess I can move it to the Booking List screen once it's merged to the trunk. Thoughts?

Testing information

Go to Settings
Developer options
Tap "Bookind details screen"

The tests that have been performed

Images/gif

Screen_recording_20250917_092317.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Copilot

Pull Request Overview

This PR implements a skeleton booking details screen feature as part of WOOMOB-1341. It creates the basic structure for displaying booking details with a configurable toolbar title.

Adds new booking details UI components including Fragment, Screen, ViewModel, and ViewState
Implements navigation to the booking details screen from developer options with hardcoded booking ID
Adds localized string resource for booking details title formatting

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
BookingDetailsViewModelTest.kt	Unit test for ViewModel toolbar title formatting logic
strings.xml	Adds localized string resource for booking details title
nav_graph_settings.xml	Navigation setup for booking details fragment with bookingId argument
DeveloperOptionsViewModel.kt	Adds booking details navigation option to developer menu
DeveloperOptionsFragment.kt	Implements navigation action to booking details with hardcoded ID
BookingDetailsViewState.kt	Data class defining the view state structure
BookingDetailsViewModel.kt	ViewModel handling toolbar title formatting from navigation args
BookingDetailsScreen.kt	Composable UI implementation with toolbar and empty content
BookingDetailsFragment.kt	Fragment wrapper for the Compose screen
build.gradle	Adds lifecycle runtime compose dependency

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...merce/src/main/kotlin/com/woocommerce/android/ui/prefs/developer/DeveloperOptionsFragment.kt

wpmobilebot · 2025-09-16T16:20:13Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`c9b6987`
	Direct Download	`woocommerce-wear-prototype-build-pr14620-c9b6987.apk`

wpmobilebot · 2025-09-16T16:36:58Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`c9b6987`
	Direct Download	`woocommerce-prototype-build-pr14620-c9b6987.apk`

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsScreen.kt

codecov-commenter · 2025-09-16T16:49:35Z

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.51%. Comparing base (dee76d3) to head (c9b6987).
⚠️ Report is 14 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...id/ui/prefs/developer/DeveloperOptionsViewModel.kt	72.72%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14620      +/-   ##
============================================
+ Coverage     38.50%   38.51%   +0.01%     
- Complexity     9774     9779       +5     
============================================
  Files          2066     2068       +2     
  Lines        115514   115538      +24     
  Branches      15390    15390              
============================================
+ Hits          44476    44497      +21     
- Misses        66906    66909       +3     
  Partials       4132     4132

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

...merce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewModel.kt

JorgeMucientes · 2025-09-18T06:09:30Z

...mmerce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsFragment.kt

+        return ComposeView(requireContext()).apply {
+            setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
+            setContent {
+                WooThemeWithBackground {


Minor np. We have a composeView() extension that provides these code for you.

PS: I've noticed in my prior PR when adding BookingListFragment that I was guilty of not using this extension either 😅

Ohh, thanks! I will update it!

...merce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewModel.kt

JorgeMucientes · 2025-09-18T07:42:44Z

WooCommerce/build.gradle

    implementation(libs.androidx.fragment.ktx)
    implementation(libs.androidx.lifecycle.viewmodel.savedstate)
    implementation(libs.androidx.lifecycle.process)
+    implementation(libs.androidx.lifecycle.runtime.compose)


Minor np. I'm not sure this dependency is needed. It is already part of androidx.lifecycle:lifecycle-viewmodel-compose.
Is there a reason why you added this specifically?

It was added to get access to .collectAsStateWithLifecycle(), but since we won't be using it, I will remove it!

…oking_details_fragment

wpmobilebot · 2025-09-22T09:36:09Z

Project manifest changes for WooCommerce

The following changes in the WooCommerce's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt	2025-09-22 09:36:05.369677713 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt	2025-09-22 09:36:08.499700251 +0000
@@ -622,17 +622,6 @@
             android:exported="false"
             android:theme="@android:style/Theme.Translucent.NoTitleBar" />
 
-        <provider
-            android:name="zendesk.belvedere.BelvedereFileProvider"
-            android:authorities="com.woocommerce.android.belvedere2.attachments"
-            android:exported="false"
-            android:grantUriPermissions="true"
-            android:readPermission="true" >
-            <meta-data
-                android:name="android.support.FILE_PROVIDER_PATHS"
-                android:resource="@xml/belvedere_attachment_storage_v2" />
-        </provider>
-
         <service
             android:name="androidx.work.impl.background.systemalarm.SystemAlarmService"
             android:directBootAware="false"
@@ -771,6 +760,16 @@
             android:required="false" />
 
         <provider
+            android:name="zendesk.belvedere.BelvedereFileProvider"
+            android:authorities="com.woocommerce.android.belvedere2.attachments"
+            android:exported="false"
+            android:grantUriPermissions="true"
+            android:readPermission="true" >
+            <meta-data
+                android:name="android.support.FILE_PROVIDER_PATHS"
+                android:resource="@xml/belvedere_attachment_storage_v2" />
+        </provider>
+        <provider
             android:name="com.google.firebase.provider.FirebaseInitProvider"
             android:authorities="com.woocommerce.android.firebaseinitprovider"
             android:directBootAware="true"

Go to https://buildkite.com/automattic/woocommerce-android/builds/32240/canvas?sid=019970c4-14f4-4b9a-a0dd-da99e747c014, click on the Artifacts tab and audit the files.

AdamGrzybkowski · 2025-09-22T09:38:34Z

@JorgeMucientes I applied the changes.

Any thoghts on this:

For now, I've added an extra row to the "Developer options" to open the Booking details screen with a fixed ID. Not sure if that's the best place, but this seemed like a good fit to make sure it's only available in debug builds.
I guess I can move it to the Booking List screen once it's merged to the trunk. Thoughts?

JorgeMucientes

Thanks for addressing the changes @AdamGrzybkowski. Everything LGTM 👏🏼

Any thoghts on this:
For now, I've added an extra row to the "Developer options" to open the Booking details screen with a fixed ID. Not sure if that's the best place, but this seemed like a good fit to make sure it's only available in debug builds.
I guess I can move it to the Booking List screen once it's merged to the trunk. Thoughts?

About that, I think it's fine the approach you followed as it will take a few days to have the booking list ready, so its a good place to provide an access point to booking detail in the meantime. Good idea!

AdamGrzybkowski added this to the 23.3 milestone Sep 16, 2025

AdamGrzybkowski added the feature: CIAB Mobile Bookings MVP label Sep 16, 2025

AdamGrzybkowski changed the title ~~Issue/woomob 1341 booking details fragment~~ [WOOMOB-1341] Booking details fragment skeleton Sep 16, 2025

AdamGrzybkowski requested a review from Copilot September 16, 2025 16:14

Copilot AI reviewed Sep 16, 2025

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/ui/prefs/developer/DeveloperOptionsFragment.kt Show resolved Hide resolved

github-advanced-security bot found potential problems Sep 16, 2025

View reviewed changes

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsScreen.kt Fixed Show fixed Hide fixed

AdamGrzybkowski added 2 commits September 17, 2025 09:24

Create new empty BookingDetailsFragment with Toolbar

2014d0b

Add temporary navigation to BookingDetails from developer options

30e8917

AdamGrzybkowski force-pushed the issue/WOOMOB-1341_booking_details_fragment branch from 0092062 to 30e8917 Compare September 17, 2025 07:25

AdamGrzybkowski requested review from JorgeMucientes and hichamboushaba September 17, 2025 07:35

AdamGrzybkowski marked this pull request as ready for review September 17, 2025 07:36

AdamGrzybkowski commented Sep 17, 2025

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewModel.kt Show resolved Hide resolved

...merce/src/main/kotlin/com/woocommerce/android/ui/bookings/details/BookingDetailsViewModel.kt Show resolved Hide resolved

JorgeMucientes self-assigned this Sep 17, 2025

AdamGrzybkowski modified the milestones: 23.3, 23.4 Sep 17, 2025

JorgeMucientes reviewed Sep 18, 2025

View reviewed changes

AdamGrzybkowski added 3 commits September 22, 2025 11:10

Expose viewState as LiveData from Booking Details VM

67b201a

Use Fragment.composeView extension in BookingDetailsFragment

5e84b8d

Merge remote-tracking branch 'origin/trunk' into issue/WOOMOB-1341_bo…

c9b6987

…oking_details_fragment

AdamGrzybkowski requested a review from JorgeMucientes September 22, 2025 09:31

JorgeMucientes approved these changes Sep 22, 2025

View reviewed changes

AdamGrzybkowski merged commit f526bad into trunk Sep 22, 2025
15 checks passed

AdamGrzybkowski deleted the issue/WOOMOB-1341_booking_details_fragment branch September 22, 2025 11:52

AdamGrzybkowski mentioned this pull request Nov 17, 2025

[Bookings] Error and loading states for Team member filter screen #14980

Merged

1 task

[WOOMOB-1341] Booking details fragment skeleton #14620

[WOOMOB-1341] Booking details fragment skeleton #14620

Uh oh!

Conversation

AdamGrzybkowski commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

The tests that have been performed

Images/gif

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

wpmobilebot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

JorgeMucientes Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JorgeMucientes Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Sep 22, 2025

Project manifest changes for WooCommerce

Uh oh!

AdamGrzybkowski commented Sep 22, 2025

Uh oh!

JorgeMucientes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AdamGrzybkowski commented Sep 16, 2025 •

edited

Loading

wpmobilebot commented Sep 16, 2025 •

edited

Loading

wpmobilebot commented Sep 16, 2025 •

edited

Loading

codecov-commenter commented Sep 16, 2025 •

edited

Loading