Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Sep 17, 2025

Description

Migrates the NotificationSettingsScreen from Material 2 to Material 3 components and theming.

Changes

  • Updated imports from androidx.compose.material to androidx.compose.material3
  • Changed MaterialTheme.colors to MaterialTheme.colorScheme
  • Updated typography references:
    • MaterialTheme.typography.subtitle1MaterialTheme.typography.titleMedium
    • MaterialTheme.typography.body2MaterialTheme.typography.bodyMedium

Steps to reproduce

  1. Open the app and navigate to Settings → Notifications
  2. To see the "Enable cha-ching sound" option, first change the notification sound:
    • Go to device Settings → Apps → WooCommerce → Notifications
    • Find "New order" notification channel and change its sound to something other than default
    • Return to the app settings to see the option appear

Before

Screenshot 2025-09-17 at 15 35 26

After

Screenshot 2025-09-17 at 15 33 32

- Updated imports from Material 2 to Material 3
- Changed MaterialTheme.colors to MaterialTheme.colorScheme
- Updated typography from titleMedium/bodyMedium
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitfe64e17
Direct Downloadwoocommerce-wear-prototype-build-pr14628-fe64e17.apk

@kidinov kidinov changed the title Migrate NotificationSettingsScreen to Material 3 [HACK] Migrate NotificationSettingsScreen to Material 3 Sep 17, 2025
@kidinov kidinov added this to the 23.4 milestone Sep 17, 2025
@kidinov kidinov marked this pull request as ready for review September 17, 2025 13:37
@kidinov kidinov requested a review from samiuelson September 17, 2025 13:38
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitfe64e17
Direct Downloadwoocommerce-prototype-build-pr14628-fe64e17.apk

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.45%. Comparing base (04e1fe1) to head (fe64e17).
⚠️ Report is 30 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14628      +/-   ##
============================================
- Coverage     38.45%   38.45%   -0.01%     
+ Complexity     9753     9752       -1     
============================================
  Files          2061     2061              
  Lines        115385   115385              
  Branches      15360    15360              
============================================
- Hits          44373    44372       -1     
  Misses        66898    66898              
- Partials       4114     4115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samiuelson samiuelson self-assigned this Sep 18, 2025
Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samiuelson samiuelson merged commit a23658c into trunk Sep 18, 2025
25 checks passed
@samiuelson samiuelson deleted the hack-migrate-NotificationSettingsScreen-to-material3 branch September 18, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants