Skip to content

Conversation

@hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Sep 17, 2025

Closes WOOMOB-1278

Description

This PR adds logic to hide split shipments feature for CIAB sites.

Steps to reproduce

  1. Use a CIAB site (Check this for creating a demo site pdpAdu-29A-p2)
  2. Install WooCommerce Shipping plugin, and connect it to WordPress.com (using the banner that appears after installing it)
  3. Open the app, and open or create an order with multiple items.
  4. Tap on Create shipping labels.
  5. Check that the "Split shipment" button is hidden.
  6. Open the order in wp-admin, then tap on "Create shipping labels", then split it to multiple shipments.
  7. Re-open the order in the mobile app (you would need to go back to order details and refresh to fetch the new shipments list)
  8. Check that the "pencil" button is hidden.

Testing information

  • Confirm that split shipments feature is hidden for both orders with single shipments and multiple shipments.
  • Good to test: confirm there is no impact for other sites.

The tests that have been performed

The above.

Images/gif

Before After
Screenshot_20250918_114010 Screenshot_20250918_113852
Screenshot_20250918_114045 Screenshot_20250918_114132
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit454a031
Direct Downloadwoocommerce-wear-prototype-build-pr14631-454a031.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit454a031
Direct Downloadwoocommerce-prototype-build-pr14631-454a031.apk

@hichamboushaba hichamboushaba force-pushed the issue/WOOMOB-1278-ciab-hide-split-shipments branch from d19ba63 to 454a031 Compare September 17, 2025 17:44
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.49%. Comparing base (8e165c0) to head (454a031).

Files with missing lines Patch % Lines
...hippinglabels/WooShippingLabelCreationViewModel.kt 50.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14631   +/-   ##
=========================================
  Coverage     38.49%   38.49%           
  Complexity     9767     9767           
=========================================
  Files          2064     2064           
  Lines        115429   115433    +4     
  Branches      15370    15372    +2     
=========================================
+ Hits          44430    44437    +7     
+ Misses        66883    66876    -7     
- Partials       4116     4120    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hichamboushaba hichamboushaba marked this pull request as ready for review September 18, 2025 10:47
@hichamboushaba hichamboushaba added this to the 23.3 milestone Sep 18, 2025
@AdamGrzybkowski AdamGrzybkowski self-assigned this Sep 22, 2025
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Confirm that split shipments feature is hidden for both orders with single shipments and multiple shipments - ✅
Good to test: confirm there is no impact for other sites - ✅

@AdamGrzybkowski AdamGrzybkowski modified the milestones: 23.3, 23.4 Sep 22, 2025
@AdamGrzybkowski AdamGrzybkowski merged commit 162e7eb into trunk Sep 22, 2025
21 of 22 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the issue/WOOMOB-1278-ciab-hide-split-shipments branch September 22, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants