-
Notifications
You must be signed in to change notification settings - Fork 136
[HACK] Remove unused resources #14632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14632 +/- ##
=========================================
Coverage 38.49% 38.49%
- Complexity 9767 9768 +1
=========================================
Files 2064 2064
Lines 115429 115429
Branches 15370 15370
=========================================
+ Hits 44430 44434 +4
+ Misses 66883 66880 -3
+ Partials 4116 4115 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
malinajirka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Remove unused color, drawable, dimension, and string resources identified by Android lint. This cleanup reduces the APK size by removing approximately 700+ unused string resources, 30+ color definitions, 20+ dimension values, and 15+ drawable files that are no longer referenced in the codebase.
Changes include:
Steps to reproduce
./gradlew assembleVanillaDebugTesting information
While green CI should be enough, scan through the changes to make sure that none of the deleted resources were used in runtime
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.