[POS][Local Catalog] Connect product list to POS database #14636

samiuelson · 2025-09-19T10:01:24Z

Description

The goal of this PR is to load products from the DB instead of the existing in-memory cache / remote call hybrid store. Currently, the logic that decides on which data source to use is based on the feature flag WOO_POS_LOCAL_CATALOG_M1 state.

⚠️ Known issue: WOOMOB-1370 - variations have wrong names. This will be solved in a separate PR.

Steps to reproduce

—

Testing information

Verify that in the release build (FF disabled), the previous data source implementation is used.
Verify that PTR works when FF is disabled.
When the FF is enabled, verify that products load correctly - full list. They should load significantly faster without pagination.

The tests that have been performed

Above

Images/gif

N/A

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

wpmobilebot · 2025-09-19T10:06:27Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`0f3456a`
	Direct Download	`woocommerce-wear-prototype-build-pr14636-0f3456a.apk`

wpmobilebot · 2025-09-19T10:19:47Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`0f3456a`
	Direct Download	`woocommerce-prototype-build-pr14636-0f3456a.apk`

…tch-products-and' into woomob-1072-woo-poslocal-catalog-connect-product-list-to-pos-products

Copilot

Pull Request Overview

This PR integrates local database storage for the POS product catalog, controlled by the WOO_POS_LOCAL_CATALOG_M1 feature flag. When enabled, products are loaded from the local database instead of the existing cache/remote hybrid approach.

Adds sorting by product name (case-insensitive) at the database level
Introduces a new database-backed data source for products with search filtering capabilities
Updates product retrieval logic in cart and totals repositories to support both local catalog and legacy flows

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
WooPosProductsDao.kt	Adds case-insensitive sorting by name to database query
WooPosProductsInDbDataSource.kt	New data source implementation for database-backed product loading
WooPosProductsDataSourceInterface.kt	Interface to unify different product data source implementations
WooPosProductsViewModel.kt	Updates to use feature flag-based data source selection
WooPosTotalsRepository.kt	Adds conditional product retrieval from local catalog
WooPosCartViewModel.kt	Adds conditional product retrieval from local catalog
Test files	Updates and new tests to support the changes

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...kotlin/com/woocommerce/android/ui/woopos/home/items/products/WooPosProductsInDbDataSource.kt

codecov-commenter · 2025-09-19T14:23:57Z

Codecov Report

❌ Patch coverage is 44.82759% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.42%. Comparing base (105f3a4) to head (0f3456a).
⚠️ Report is 29 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...id/ui/woopos/common/data/WooPosGetVariationById.kt	0.00%	15 Missing ⚠️
...pos/home/items/products/WooPosProductsViewModel.kt	50.00%	3 Missing and 2 partials ⚠️
...android/ui/woopos/home/cart/WooPosCartViewModel.kt	0.00%	0 Missing and 3 partials ⚠️
...os/home/items/products/WooPosProductsDataSource.kt	50.00%	3 Missing ⚠️
...id/ui/woopos/home/totals/WooPosTotalsRepository.kt	0.00%	2 Missing and 1 partial ⚠️
...ome/items/products/WooPosProductsInDbDataSource.kt	87.50%	1 Missing and 1 partial ⚠️
...home/items/variations/WooPosVariationsViewModel.kt	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #14636   +/-   ##
=========================================
  Coverage     38.42%   38.42%           
- Complexity     9812     9818    +6     
=========================================
  Files          2086     2087    +1     
  Lines        116448   116470   +22     
  Branches      15563    15563           
=========================================
+ Hits          44748    44757    +9     
- Misses        67549    67562   +13     
  Partials       4151     4151

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...erce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/WooPosTotalsRepository.kt

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartViewModel.kt

kidinov · 2025-09-30T09:19:55Z

...main/kotlin/com/woocommerce/android/ui/woopos/home/items/products/WooPosProductsViewModel.kt


    init {
        listenEventsFromParent()
+        viewModelScope.launch {


Do we need this or should the data source object be created every time when the VM is created?

It's not needed since fetchFirstPage() already handles the state reset internally. Removed: 0f3456a

kidinov · 2025-09-30T09:27:46Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartViewModel.kt

    private suspend fun handleSimpleProductClicked(productId: Long): WooPosCartItemViewState {
-        val product = getProductById(productId)!!
+        val product = when {
+            wooPosLocalCatalogM1Enabled() -> {


I think it'll be better to have this logic in WooPosGetProductById as this reusable component that used in many places. wdyt?

Yeah, good idea. Done in b1e60e4

kidinov · 2025-09-30T09:28:51Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartViewModel.kt

    private suspend fun handleVariationClicked(productId: Long, variationId: Long): WooPosCartItemViewState {
-        val product = getProductById(productId)!!
+        val product = when {
+            wooPosLocalCatalogM1Enabled() -> {


Even in this VM you have the same code twice, so imo should be in getProductById

Refactored in b1e60e4

kidinov · 2025-09-30T09:34:59Z

...erce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/totals/WooPosTotalsRepository.kt

+            else -> getProductById(itemData.productId)!!
+        }
+        val variationResult = when {
+            wooPosLocalCatalogM1Enabled() -> {


Same here for getVariationById

Done in b1e60e4

kidinov · 2025-09-30T09:38:23Z

...main/kotlin/com/woocommerce/android/ui/woopos/home/items/products/WooPosProductsViewModel.kt

    private val resourceProvider: ResourceProvider,
 ) : ViewModel() {
+
+    private val currentDataSource: WooPosProductsDataSourceInterface = when (wooPosLocalCatalogM1Enabled()) {


Have you considered moving this to the place where the instance is created, e.g. in dagger module? So the right implementation will be injected everywhere where needed?

Good point. Moved this to the module: 57b2078

kidinov

LGTM! I left a couple of comments, please take a look!

…oduct-list-to-pos-products

samiuelson added 4 commits September 19, 2025 11:33

Get product from DB in Cart

744aabf

Update test

ed171b0

Create in-DB products data source

69e53d4

Plug in in-DB products data source into products VM

3737d65

samiuelson added 4 commits September 19, 2025 12:23

Sort products by name lowercase

0350226

Get variation and product from DB in totals screen

8966f1c

Satisfy detekt's complaints

fe4f6b0

Fix tests

267d0c7

samiuelson changed the base branch from trunk to woomob-1069-woo-poslocal-catalog-update-ptr-behavior-fetch-products-and September 19, 2025 12:18

Merge branch 'woomob-1069-woo-poslocal-catalog-update-ptr-behavior-fe…

553d120

…tch-products-and' into woomob-1072-woo-poslocal-catalog-connect-product-list-to-pos-products

samiuelson added this to the 23.4 milestone Sep 19, 2025

samiuelson added feature: point of sale POS project type: task An internally driven task. labels Sep 19, 2025

samiuelson requested a review from Copilot September 19, 2025 12:22

Copilot AI reviewed Sep 19, 2025

View reviewed changes

...kotlin/com/woocommerce/android/ui/woopos/home/items/products/WooPosProductsInDbDataSource.kt Outdated Show resolved Hide resolved

samiuelson added 3 commits September 19, 2025 14:53

Clean up code

1892909

Clean up code

b00c544

Fix variation fetching in totals

6ad04db

samiuelson marked this pull request as ready for review September 19, 2025 14:49

samiuelson requested review from Copilot and malinajirka September 19, 2025 14:50

Copilot AI reviewed Sep 19, 2025

View reviewed changes

samiuelson requested review from kidinov and removed request for malinajirka September 29, 2025 15:45

kidinov self-assigned this Sep 30, 2025

kidinov reviewed Sep 30, 2025

View reviewed changes

kidinov approved these changes Sep 30, 2025

View reviewed changes

Base automatically changed from woomob-1069-woo-poslocal-catalog-update-ptr-behavior-fetch-products-and to trunk September 30, 2025 13:53

samiuelson added 5 commits September 30, 2025 15:59

Merge branch 'trunk' into woomob-1072-woo-poslocal-catalog-connect-pr…

c20b3cf

…oduct-list-to-pos-products

Clean up WooPosLocalCatalogM1Enabled feature flag checks

b1e60e4

Satisfy detekt's complaints

a5361f2

Move FF check from VM to the Dagger module

57b2078

Remove redundant code

0f3456a

samiuelson enabled auto-merge September 30, 2025 17:00

samiuelson merged commit e86309e into trunk Sep 30, 2025
15 checks passed

samiuelson deleted the woomob-1072-woo-poslocal-catalog-connect-product-list-to-pos-products branch September 30, 2025 17:07

[POS][Local Catalog] Connect product list to POS database #14636

[POS][Local Catalog] Connect product list to POS database #14636

Uh oh!

Conversation

samiuelson commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Uh oh!

wpmobilebot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

codecov-commenter commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kidinov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

samiuelson commented Sep 19, 2025 •

edited

Loading

wpmobilebot commented Sep 19, 2025 •

edited

Loading

wpmobilebot commented Sep 19, 2025 •

edited

Loading

codecov-commenter commented Sep 19, 2025 •

edited

Loading