Skip to content

Conversation

@iangmaia
Copy link
Contributor

See p1758259272770889-slack-CC7L49W13

Description

We've noticed during a release that using a fine-grained token for the woocommerce org now fails when trying to access private libraries in the localize_libs lane.

This PR then introduces the separate token AUTOMATTIC_GITHUB_TOKEN_READ_ONLY used only when calling android_download_file_by_version.

@iangmaia iangmaia self-assigned this Sep 22, 2025
@iangmaia iangmaia added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Sep 22, 2025
@iangmaia iangmaia added this to the 23.4 milestone Sep 22, 2025
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you plan to soon push a commit to .mobile-secrets to add that AUTOMATTIC_GITHUB_TOKEN_READ_ONLY env var to it, right?

I haven't seen that commit in .mobile-secrets yet so just 🎗️ to maybe not merge this PR until it's added too.

@iangmaia
Copy link
Contributor Author

I'm guessing you plan to soon push a commit to .mobile-secrets to add that AUTOMATTIC_GITHUB_TOKEN_READ_ONLY env var to it, right?

I haven't seen that commit in .mobile-secrets yet so just 🎗️ to maybe not merge this PR until it's added too.

I've requested a fine-grained token but it hasn't been approved yet.
For now and to be able to merge this in time for the release tomorrow, I'll use a classic token in .mobile-secrets and once the fine-grained one gets approved I'll replace it.

@iangmaia iangmaia merged commit 2859f05 into trunk Sep 25, 2025
19 checks passed
@iangmaia iangmaia deleted the iangmaia/add-separate-token-for-libs branch September 25, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants