Skip to content

Revert okhttp update due to issue with IPP #14679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Revert okhttp update due to issue with IPP #14679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcbd7d9
Revert okhttp update due to issue with IPP
malinajirka Oct 2, 2025
78b8a5d
Update release notes
malinajirka Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
-----


23.3.1
-----
- [***] Fix broken IPP flow [https://github.com/woocommerce/woocommerce-android/pull/14679[
23.3
-----
- [Internal] Migration to POS specific product model [https://github.com/woocommerce/woocommerce-android/pull/14598]
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ robolectric = "4.14"
sentry = '5.8.0'
squareup-javapoet = "1.7.0"
squareup-leakcanary = '2.14'
squareup-okhttp3 = "5.1.0"
squareup-okhttp3 = "4.9.0"
stripe-terminal = '4.6.0'
tinder-statemachine = '0.2.0'
volley = "1.1.1"
Expand Down
4 changes: 2 additions & 2 deletions libs/apifaker/src/main/java/com/woocommerce/android/apifaker/ApiFakerInterceptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import okhttp3.Interceptor.Chain
import okhttp3.MediaType.Companion.toMediaType
import okhttp3.Protocol
import okhttp3.Response
import okhttp3.ResponseBody
import okhttp3.ResponseBody.Companion.toResponseBody
import okhttp3.internal.EMPTY_RESPONSE
import javax.inject.Inject

private const val ARTIFICIAL_DELAY_MS = 500L
Expand Down Expand Up @@ -41,7 +41,7 @@ internal class ApiFakerInterceptor @Inject constructor(
.code(fakeResponse.statusCode)
// TODO check if it's safe to always use JSON as the content type
.body(
fakeResponse.body?.toResponseBody("application/json".toMediaType()) ?: ResponseBody.EMPTY
fakeResponse.body?.toResponseBody("application/json".toMediaType()) ?: EMPTY_RESPONSE
)
.addHeader("content-type", "application/json")
.build()
Expand Down