Skip to content

Conversation

@hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Oct 2, 2025

Closes WOOMOB-1404

Description

This PR updates the logic of filtering to match what the API expects, because the API stores dates without timezone information (dates stored as strings), it ignores any timezone information when filtering, so to get the correct results for date filtering, we need to send the dates as UTC.

Steps to reproduce

  1. Prepare a CIAB site with bookings (check previous PRs for steps if needed).
  2. Create some bookings.
  3. Confirm Today and Upcoming behave as expected.

Testing information

  • Check the bookings times listed on the server, and confirm that Today lists all bookings for today, and Upcoming lists all future bookings (from tomorrow midnight).

The tests that have been performed

  • The above.
  • Also I created a booking at 11:30pm on the server, and confirmed that the logic now works well, as this booking wasn't shown before for today (my local timezone is UTC+1).

Images/gif

Before (missing one booking) After
Screenshot_20251002_181303 Screenshot_20251002_182207
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba marked this pull request as ready for review October 2, 2025 18:11
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit388529f
Direct Downloadwoocommerce-wear-prototype-build-pr14686-388529f.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit388529f
Direct Downloadwoocommerce-prototype-build-pr14686-388529f.apk

@hichamboushaba hichamboushaba added this to the 23.5 milestone Oct 2, 2025
@AdamGrzybkowski AdamGrzybkowski self-assigned this Oct 3, 2025
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filtering now works correctly!

@AdamGrzybkowski AdamGrzybkowski merged commit 10ed2e6 into trunk Oct 3, 2025
24 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the issue/WOOMOB-1404-bookings-date-updates branch October 3, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants