-
Notifications
You must be signed in to change notification settings - Fork 136
[WOOMOB-1428][Woo POS][Surveys] Show potential user push notification after order creation #14703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOMOB-1428][Woo POS][Surveys] Show potential user push notification after order creation #14703
Conversation
…chedular and update method for scheduling potential user survey notifications
…ened before scheduling potential user survey notifications
…notification-that' into woomob-1428-woo-possurveys-show-potential-push-notification-after-order
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
…pdate country code retrieval
…ification scheduling logic
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…ush-notification-after-order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to show a local push notification to potential WooCommerce POS users after they create an order in the main WooCommerce app. The notification is shown only once per user and only for merchants in the US and UK.
- Created
WooPosSurveysNotificationSchedularclass to handle notification scheduling with country restrictions - Integrated notification trigger in
OrderCreateEditViewModelafter successful order creation - Added feature flag
WOO_POS_SURVEYSto control the notification functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WooPosSurveysNotificationSchedular.kt | New scheduler class handling notification logic with country and feature flag checks |
| WooPosSurveysNotificationSchedularTest.kt | Comprehensive test coverage for the notification scheduler |
| OrderCreateEditViewModel.kt | Integration point to trigger notification after successful order creation |
| UnifiedOrderEditViewModelTest.kt | Test setup updated to include the new notification scheduler dependency |
| FeatureFlag.kt | Added WOO_POS_SURVEYS feature flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ush-notification-after-order
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14703 +/- ##
============================================
+ Coverage 38.37% 38.39% +0.01%
- Complexity 9855 9866 +11
============================================
Files 2099 2100 +1
Lines 117044 117064 +20
Branches 15657 15661 +4
============================================
+ Hits 44913 44941 +28
+ Misses 67964 67954 -10
- Partials 4167 4169 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WOOMOB-1428
Description
This PR adds functionality to show a local push notification to potential Woo POS users after they create an order in the main WooCommerce app. The notification is shown only once per user and only for merchants in the US and UK.
The notification is shown, but click on it is not handled.
The implementation includes:
WooPosSurveysNotificationSchedularclass to handle notification schedulingOrderCreateEditViewModelafter successful order creationSteps to reproduce
WOO_POS_SURVEYSfeature flagTesting information
The tests that have been performed
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.