[WOOMOB-1446] Implement cellular data preference for WooPos local catalog sync #14725

malinajirka · 2025-10-09T09:17:56Z

Description

Implements cellular data preference functionality for WooPos local catalog synchronization. When users disable "Download over cellular" in the local catalog settings, background sync operations will only run when connected to WiFi, preventing unexpected data usage charges.

The implementation uses WorkManager's built-in network constraints at the OS level for optimal efficiency - the system won't even start the worker when network conditions don't match the user's preferences.

Testing information

Verify the cellular data toggle appears in WooPos local catalog settings
Test that toggling the preference saves the setting persistently
Confirm worker is rescheduled with updated constraints when you update the toggle

The tests that have been performed

The above

wpmobilebot · 2025-10-09T09:24:13Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e54cf5c`
	Direct Download	`woocommerce-wear-prototype-build-pr14725-e54cf5c.apk`

…-downloadovercellular-preference-in # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogViewModel.kt

Copilot

Pull Request Overview

This PR implements cellular data preference functionality for WooPos local catalog synchronization, allowing users to restrict background sync operations to WiFi only to prevent unexpected data usage charges.

Key changes:

Added a new preference setting to control cellular data usage for sync operations
Updated WorkManager constraints to respect user preference (WiFi-only or any connection)
Integrated the preference toggle into the local catalog settings UI

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
WooPosPreferencesRepository.kt	Adds storage and retrieval methods for the cellular data preference
WooPosSettingsLocalCatalogViewModel.kt	Integrates preference loading/saving with UI state and triggers constraint updates
WooPosLocalCatalogSyncScheduler.kt	Updates WorkManager constraints based on user preference and handles work rescheduling

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...ain/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosLocalCatalogSyncScheduler.kt

…-downloadovercellular-preference-in

wpmobilebot · 2025-10-09T16:40:33Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e54cf5c`
	Direct Download	`woocommerce-prototype-build-pr14725-e54cf5c.apk`

codecov-commenter · 2025-10-09T17:01:30Z

Codecov Report

❌ Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.42%. Comparing base (d8fe4c0) to head (e54cf5c).
⚠️ Report is 100 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...os/localcatalog/WooPosLocalCatalogSyncScheduler.kt	0.00%	45 Missing ⚠️
...ocalcatalog/WooPosSettingsLocalCatalogViewModel.kt	0.00%	11 Missing ⚠️
...opos/util/datastore/WooPosPreferencesRepository.kt	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #14725      +/-   ##
============================================
- Coverage     38.43%   38.42%   -0.02%     
  Complexity     9887     9887              
============================================
  Files          2105     2105              
  Lines        117088   117122      +34     
  Branches      15646    15646              
============================================
  Hits          45001    45001              
- Misses        67914    67948      +34     
  Partials       4173     4173

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

malinajirka · 2025-10-10T06:06:31Z

...ain/kotlin/com/woocommerce/android/ui/woopos/localcatalog/WooPosLocalCatalogSyncScheduler.kt

+
+            workManager.enqueueUniquePeriodicWork(
+                WooPosLocalCatalogSyncWorker.WORK_NAME,
+                ExistingPeriodicWorkPolicy.UPDATE,


📓 I replaced Keep with Update and wrapped the block in coroutine.

kidinov · 2025-10-13T08:00:17Z

...merce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogViewModel.kt

                lastFullUpdate = formattedTimestamp // TBD local catalog: Replace with full sync timestamp
            )

+            val allowCellularDataUpdate = preferencesRepository.allowCellularDataUpdate.first()


Consider making the cellular preference fully reactive by continuously listening to the repository instead of reading it once at startup. This way the UI state always stays in sync with the stored
preference, and the Switch can pass its new value directly rather than the ViewModel toggling the current state.

Something like that. Wdyt?

Refactor_cellular_data_update_handling_to_pass_boolean_value_and_improve_state_management.patch

Thanks for the suggestion @kidinov! I'm wondering what is the benefit of observing, since the settings screen is the only place how this setting can be changed 🤔. The VM would be observing a repository that only the VM itself can change -> so the VM would update the setting and the VM would receive an update from the repo. I might be missing something, but I'm not sure what is the benefit.

Could you please elaborate on it a bit?

Unidirectional data flow: Data flows in one direction: UI → VM → Repo → VM → UI. This makes it easy to trace what's happening. No shortcuts where the VM updates itself directly.

Less code: No need to flip !_state.value.allowCellularDataUpdate - the Switch already has the new value, just save it

Can't get out of sync: Right now, if something goes wrong between updating the VM state and saving to repo, they could be different. With observing, that's impossible.

Works if anything else changes it: currently there is assumption that it can be changed only from 1 place and in sync way, but if it changes asynchronously, it'll be out of sync with the view

Bottom line: We don't maintain two copies of the same data. The repo is the source of the truth

Good points, I've tested and applied the patch 🙇.

e54cf5c

kidinov

LGTM! I left one code improvement suggestion, please take a look

malinajirka added 3 commits October 8, 2025 09:54

Add prefs for download over cellular

2a3f049

Save toggle state for download over cellular

2b9c5b4

Update local catalog worker constraints based on settings

4baf2db

Merge branch 'trunk' into issue/woomob-1446-woo-poslocal-catalog-save…

75835c5

…-downloadovercellular-preference-in # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/settings/details/localcatalog/WooPosSettingsLocalCatalogViewModel.kt

malinajirka added the feature: POS label Oct 9, 2025

malinajirka added this to the 23.5 milestone Oct 9, 2025

malinajirka requested a review from Copilot October 9, 2025 09:34

Copilot AI reviewed Oct 9, 2025

View reviewed changes

malinajirka added 2 commits October 9, 2025 11:40

Enable download over cellular by default

ffe5515

Disable catalog download when roaming

12bed58

malinajirka force-pushed the issue/woomob-1446-woo-poslocal-catalog-save-downloadovercellular-preference-in branch from 70bb768 to 12bed58 Compare October 9, 2025 10:05

malinajirka added 3 commits October 9, 2025 12:08

Use UPDATE instead of REPLACE on worker

9628fb1

Use injected application scope

0a68755

Merge branch 'trunk' into issue/woomob-1446-woo-poslocal-catalog-save…

8ab0277

…-downloadovercellular-preference-in

malinajirka requested a review from kidinov October 9, 2025 16:46

malinajirka commented Oct 10, 2025

View reviewed changes

kidinov self-assigned this Oct 13, 2025

kidinov reviewed Oct 13, 2025

View reviewed changes

kidinov approved these changes Oct 13, 2025

View reviewed changes

Observe allow cellular downloads toggle value

e54cf5c

malinajirka enabled auto-merge October 13, 2025 09:21

malinajirka merged commit d33a5c4 into trunk Oct 13, 2025
14 of 16 checks passed

malinajirka deleted the issue/woomob-1446-woo-poslocal-catalog-save-downloadovercellular-preference-in branch October 13, 2025 09:44

[WOOMOB-1446] Implement cellular data preference for WooPos local catalog sync #14725

[WOOMOB-1446] Implement cellular data preference for WooPos local catalog sync #14725

Uh oh!

Conversation

malinajirka commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

The tests that have been performed

Uh oh!

wpmobilebot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpmobilebot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

malinajirka Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

malinajirka Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

malinajirka commented Oct 9, 2025 •

edited

Loading

wpmobilebot commented Oct 9, 2025 •

edited

Loading

wpmobilebot commented Oct 9, 2025 •

edited

Loading

codecov-commenter commented Oct 9, 2025 •

edited

Loading