Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Oct 9, 2025

WOOMOB-1452
WOOMOB-1436

Description

This PR implements the click handling for WooPos survey notifications. When users tap on the survey notifications, they are now taken to the FeedbackSurveyFragment which displays the appropriate survey based on the notification type.

Changes include:

  • Added fake survey URLs for both potential and current user surveys
  • Implemented click handling in MainActivityViewModel to trigger survey navigation
  • Updated MainActivity to navigate to FeedbackSurveyFragment with custom survey URLs
  • Updated notification copy to match the new specifications

Steps to reproduce

  1. Trigger a WooPos survey notification (either potential user or current user)
  2. Tap on the notification
  3. Verify the FeedbackSurveyFragment opens with the correct survey URL

Testing information

  • Test both notification types: potential user and current user

  • Verify the correct survey URL is loaded in each case

  • Confirm the notification copy matches the specifications:

    • Potential user: "Thinking about in-person sales?" / "Take a quick 2-minute survey to help us shape features you'll love."
    • Current user: "How's POS working for you?" / "Share your experience in a quick 2-minute survey and help us improve."
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov added this to the 23.5 milestone Oct 9, 2025
@kidinov kidinov marked this pull request as ready for review October 9, 2025 14:21
@kidinov kidinov requested a review from samiuelson October 9, 2025 14:22
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit164c823
Direct Downloadwoocommerce-wear-prototype-build-pr14727-164c823.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 9, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit164c823
Direct Downloadwoocommerce-prototype-build-pr14727-164c823.apk

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.29%. Comparing base (b5f743a) to head (164c823).
⚠️ Report is 4 commits behind head on trunk.

Files with missing lines Patch % Lines
...ocommerce/android/ui/main/MainActivityViewModel.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14727      +/-   ##
============================================
- Coverage     38.30%   38.29%   -0.01%     
- Complexity    10007    10008       +1     
============================================
  Files          2116     2116              
  Lines        118367   118371       +4     
  Branches      15804    15804              
============================================
+ Hits          45335    45336       +1     
- Misses        68822    68826       +4     
+ Partials       4210     4209       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samiuelson samiuelson self-assigned this Oct 15, 2025
@samiuelson samiuelson requested a review from Copilot October 15, 2025 07:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements click handling for WooPos survey notifications, allowing users to tap on notifications and be directed to appropriate surveys. The changes enable navigation to survey screens with custom URLs based on the notification type.

  • Added click handlers for WooPos survey notifications in MainActivityViewModel
  • Created navigation logic to display surveys using FeedbackSurveyFragment with custom URLs
  • Updated notification copy text to match new specifications

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
strings.xml Updated notification description text for WooPos surveys
MainActivityViewModel.kt Added ViewSurvey event and click handlers for survey notifications
MainActivity.kt Implemented showSurvey method to navigate to FeedbackSurveyFragment
BookingListScreen.kt Added missing isFilterButtonVisible parameter to preview components
AppUrls.kt Added survey URL constants for potential and current user surveys

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 23.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samiuelson samiuelson enabled auto-merge October 15, 2025 08:01
@samiuelson samiuelson merged commit e6154f2 into trunk Oct 15, 2025
16 checks passed
@samiuelson samiuelson deleted the woomob-1452-woo-possurveys-implement-a-click-on-the-notifications-to branch October 15, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants