-
Notifications
You must be signed in to change notification settings - Fork 136
[WOOMOB-1452][Woo POS][Surveys] Implement click action on notifications to show surveys #14727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOOMOB-1452][Woo POS][Surveys] Implement click action on notifications to show surveys #14727
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14727 +/- ##
============================================
- Coverage 38.30% 38.29% -0.01%
- Complexity 10007 10008 +1
============================================
Files 2116 2116
Lines 118367 118371 +4
Branches 15804 15804
============================================
+ Hits 45335 45336 +1
- Misses 68822 68826 +4
+ Partials 4210 4209 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements click handling for WooPos survey notifications, allowing users to tap on notifications and be directed to appropriate surveys. The changes enable navigation to survey screens with custom URLs based on the notification type.
- Added click handlers for WooPos survey notifications in MainActivityViewModel
- Created navigation logic to display surveys using FeedbackSurveyFragment with custom URLs
- Updated notification copy text to match new specifications
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| strings.xml | Updated notification description text for WooPos surveys |
| MainActivityViewModel.kt | Added ViewSurvey event and click handlers for survey notifications |
| MainActivity.kt | Implemented showSurvey method to navigate to FeedbackSurveyFragment |
| BookingListScreen.kt | Added missing isFilterButtonVisible parameter to preview components |
| AppUrls.kt | Added survey URL constants for potential and current user surveys |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…k-on-the-notifications-to
samiuelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WOOMOB-1452
WOOMOB-1436
Description
This PR implements the click handling for WooPos survey notifications. When users tap on the survey notifications, they are now taken to the FeedbackSurveyFragment which displays the appropriate survey based on the notification type.
Changes include:
Steps to reproduce
Testing information
Test both notification types: potential user and current user
Verify the correct survey URL is loaded in each case
Confirm the notification copy matches the specifications:
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.