Skip to content

Conversation

@malinajirka
Copy link
Contributor

This is a quick follow up for this merged PR - #14740.

I accidentally didn't push the last commit which replaces marginRight with marginEnd to ensure RTL support.

@malinajirka malinajirka added this to the 23.5 milestone Oct 13, 2025
@malinajirka malinajirka requested a review from kidinov October 13, 2025 14:18
@malinajirka malinajirka added the category: accessibility Related to accessibility. label Oct 13, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitd029510
Direct Downloadwoocommerce-wear-prototype-build-pr14745-d029510.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitd029510
Direct Downloadwoocommerce-prototype-build-pr14745-d029510.apk

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.24%. Comparing base (a58a205) to head (d029510).
⚠️ Report is 19 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14745      +/-   ##
============================================
- Coverage     38.24%   38.24%   -0.01%     
  Complexity     9913     9913              
============================================
  Files          2111     2111              
  Lines        117860   117860              
  Branches      15700    15700              
============================================
- Hits          45081    45080       -1     
- Misses        68587    68588       +1     
  Partials       4192     4192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kidinov kidinov self-assigned this Oct 14, 2025
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!

@kidinov kidinov merged commit 233cca6 into trunk Oct 14, 2025
19 of 20 checks passed
@kidinov kidinov deleted the issue/issue/woomob-1424-analytics-loading-skeleton-overdraw branch October 14, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: accessibility Related to accessibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants