Skip to content

Conversation

@wpmobilebot
Copy link
Collaborator

Merging release/23.4 into trunk.

Via intermediate branch merge/release-23.4-into-trunk, to help fix conflicts if any:

                            release/23.4  ----o-- - - -
                                               \
           merge/release-23.4-into-trunk        `---.
                                                     \
                                   trunk  ------------x- - -

@wpmobilebot wpmobilebot added the Releases Used in release management. Using this label will skip some bot checks. label Oct 17, 2025
@wpmobilebot wpmobilebot added this to the 23.5 milestone Oct 17, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR has the Releases label: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator Author

Project manifest changes for WooCommerce

The following changes in the WooCommerce's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt	2025-10-17 11:13:50.624463652 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt	2025-10-17 11:14:00.684501787 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.woocommerce.android"
-    android:versionCode="698"
-    android:versionName="23.4-rc-2" >
+    android:versionCode="699"
+    android:versionName="23.4" >
 
     <uses-sdk
         android:minSdkVersion="26"

Go to https://buildkite.com/automattic/woocommerce-android/builds/32888/canvas?sid=0199f1db-79e5-404d-a5d6-a949eabe0481, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Collaborator Author

Project manifest changes for WooCommerce-Wear

The following changes in the WooCommerce-Wear's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/base_manifest.txt	2025-10-17 11:14:15.034556261 +0000
+++ ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/head_manifest.txt	2025-10-17 11:14:22.544581423 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.woocommerce.android"
-    android:versionCode="50698"
-    android:versionName="23.4-rc-2w" >
+    android:versionCode="50699"
+    android:versionName="23.4w" >
 
     <uses-sdk
         android:minSdkVersion="26"

Go to https://buildkite.com/automattic/woocommerce-android/builds/32888/canvas?sid=0199f1db-79e5-404d-a5d6-a949eabe0481, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Collaborator Author

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commiteec2531
Direct Downloadwoocommerce-wear-prototype-build-pr14775-eec2531.apk

@wpmobilebot
Copy link
Collaborator Author

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commiteec2531
Direct Downloadwoocommerce-prototype-build-pr14775-eec2531.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.37%. Comparing base (3146cc8) to head (eec2531).
⚠️ Report is 514 commits behind head on trunk.

Files with missing lines Patch % Lines
.../android/fluxc/network/rest/wpcom/wc/WooNetwork.kt 0.00% 9 Missing ⚠️
...xc/network/rest/wpapi/media/MediaWPRESTResponse.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14775      +/-   ##
============================================
- Coverage     38.37%   38.37%   -0.01%     
- Complexity     9824     9825       +1     
============================================
  Files          2093     2093              
  Lines        116750   116760      +10     
  Branches      15622    15623       +1     
============================================
+ Hits          44806    44808       +2     
- Misses        67785    67793       +8     
  Partials       4159     4159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JorgeMucientes JorgeMucientes self-assigned this Oct 17, 2025
@JorgeMucientes JorgeMucientes merged commit 4ad858a into trunk Oct 17, 2025
20 of 21 checks passed
@JorgeMucientes JorgeMucientes deleted the merge/release-23.4-into-trunk branch October 17, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Releases Used in release management. Using this label will skip some bot checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants