Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Oct 21, 2025

Closes WOOMOB-1552

Description

This PR updates the protolayout-expression version used transitively by the Wear app through the Horologist library. See WOOMOB-1552 for more details about the known issues with protolayout-expression:1.0.0-beta01.

Steps to reproduce

  • Launch Wear app.
  • Run ./gradlew assembleDebug --scan and in the result report, check dependencies and verify that androidx.wear.protolayout:protolayout-expression:1.0.0-beta01 is forced to
    1.2.1.

The tests that have been performed

Tested the Wear app to ensure it compiles and launches without any issues.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Upgrades `androidx.wear.protolayout` to version `1.2.1` to resolve known issues present in the version previously used by Horologist.
@irfano irfano added this to the 23.5 ❄️ milestone Oct 21, 2025
@irfano irfano requested a review from a team as a code owner October 21, 2025 18:27
@irfano irfano requested review from malinajirka and removed request for a team October 21, 2025 18:27
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 21, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.5 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
1 Message
📖 This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 Danger

@irfano irfano requested review from AdamGrzybkowski, JorgeMucientes and hichamboushaba and removed request for malinajirka October 21, 2025 18:36
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit597f812
Direct Downloadwoocommerce-wear-prototype-build-pr14797-597f812.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit597f812
Direct Downloadwoocommerce-prototype-build-pr14797-597f812.apk

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.08%. Comparing base (2ae1831) to head (597f812).

Additional details and impacted files
@@               Coverage Diff               @@
##             release/23.5   #14797   +/-   ##
===============================================
  Coverage           38.08%   38.08%           
  Complexity           9998     9998           
===============================================
  Files                2119     2119           
  Lines              119170   119170           
  Branches            16228    16228           
===============================================
+ Hits                45384    45385    +1     
+ Misses              69207    69206    -1     
  Partials             4579     4579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JorgeMucientes JorgeMucientes self-assigned this Oct 22, 2025
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @irfano. Changes look good.
I just left a question about the removed dependencies

PS: I'll create a new wearable release candidate once this is merged

androidx-test-uiautomator = '2.3.0'
androidx-transition = '1.6.0'
androidx-wear-compose = '1.4.0'
androidx-wear-tiles = '1.3.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this unused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 🤔 They're defined in libs.versions.toml for androidx-wear-tiles-main and androidx-wear-tiles-material, but they're not used anywhere.
Implementation for those were removed recently (https://github.com/woocommerce/woocommerce-android/pull/14710/files) but those left behind in libs.versions.toml.

@irfano irfano merged commit b57eeaa into release/23.5 Oct 24, 2025
16 checks passed
@irfano irfano deleted the fix/protolayout-warning branch October 24, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants