-
Notifications
You must be signed in to change notification settings - Fork 136
[Jetpack Setup] Update tracking plan #14868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetpack Setup] Update tracking plan #14868
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
28ddfe0 to
98ab309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates Jetpack activation analytics by removing feature-flag-based tracking and standardizing on a unified JETPACK_SETUP_FLOW event pattern. The changes remove the useApplicationPasswords conditional logic that maintained dual analytics systems.
Key changes:
- Unified all Jetpack setup analytics to use
JETPACK_SETUP_FLOWevent with consistent property keys (KEY_STEP,KEY_TAP,KEY_FAILURE) - Removed 18 deprecated
LOGIN_JETPACK_*analytics events - Updated
JetpackActivationStartViewModelto use the new analytics structure with a newVALUE_JETPACK_SETUP_TAP_CONTINUE_SETUPconstant
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| JetpackActivationMainViewModel.kt | Removed conditional analytics logic based on useApplicationPasswords flag; consolidated all tracking to use trackSetupFlow() method |
| JetpackActivationStartViewModel.kt | Updated analytics events to use JETPACK_SETUP_FLOW pattern with appropriate step and tap properties |
| JetpackActivationRepository.kt | Removed direct analytics tracking and unused AnalyticsTrackerWrapper dependency |
| AnalyticsTracker.kt | Added new VALUE_JETPACK_SETUP_TAP_CONTINUE_SETUP constant for continue action tracking |
| AnalyticsEvent.kt | Removed 18 deprecated LOGIN_JETPACK_* analytics event enum values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../main/kotlin/com/woocommerce/android/ui/login/jetpack/main/JetpackActivationMainViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/woocommerce/android/ui/login/jetpack/main/JetpackActivationMainViewModel.kt
Outdated
Show resolved
Hide resolved
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
d6b6ac7 to
895f0b1
Compare
irfano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works as expected. 👍🏻
Closes WOOMOB-1010
Description
For historical reasons, we were using different tracking plan for the Jetpack Setup depending on how it was opened:
login_jetpack_setupjetpack_setup_flow), and we use properties to add more detailsWith the last project to integrate the Jetpack Connection API, we decided to unify the tracking between the two flows, and this was implemented in iOS in this PR woocommerce/woocommerce-ios#15999, this Android PR handles the same change.
Test Steps
A good code review is better for this PR just to confirm I did the right action for all the locations.
For testing, please follow this:
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.