-
Notifications
You must be signed in to change notification settings - Fork 136
[POS Orders] Analytics Improvement #14873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
kidinov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Maybe then also include the fix for the "order details loaded" tracking here?
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14873 +/- ##
=========================================
Coverage 38.27% 38.27%
Complexity 10088 10088
=========================================
Files 2130 2130
Lines 120787 120789 +2
Branches 16540 16540
=========================================
+ Hits 46227 46229 +2
Misses 69864 69864
Partials 4696 4696 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WOOMOB-1155
Description
With this PR we track
pos_orders_list_fetchedandpos_orders_list_search_results_fetchedwhen requests failed, as the original event intent. Read more hereTest Steps
pos_orders_list_fetchedis also tracked in that caseRepeat the same with the search and the
pos_orders_list_search_results_fetchedeventRELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.