Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Oct 31, 2025

WOOMOB-1155

Description

With this PR we track pos_orders_list_fetched and pos_orders_list_search_results_fetched when requests failed, as the original event intent. Read more here

Test Steps

  1. Go to POS
  2. Turn device into flight mode to make the request fail -or find another way to make it so-
  3. Go to Orders
  4. See that pos_orders_list_fetched is also tracked in that case

Repeat the same with the search and the pos_orders_list_search_results_fetched event

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@toupper toupper added this to the 23.6 milestone Oct 31, 2025
@toupper toupper requested a review from kidinov October 31, 2025 08:49
@toupper toupper added feature: analytics In-app store analytics feature: POS labels Oct 31, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 31, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@toupper toupper added the category: tracks Related to analytics, including Tracks Events. label Oct 31, 2025
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe then also include the fix for the "order details loaded" tracking here?

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit0e4f66e
Direct Downloadwoocommerce-wear-prototype-build-pr14873-0e4f66e.apk

@toupper toupper enabled auto-merge October 31, 2025 08:58
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit0e4f66e
Direct Downloadwoocommerce-prototype-build-pr14873-0e4f66e.apk

@toupper toupper merged commit 91166fd into trunk Oct 31, 2025
22 of 24 checks passed
@toupper toupper deleted the feat/WOOMOB-1155-POS-Orders-analytics-fix branch October 31, 2025 09:22
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.27%. Comparing base (3c11cd3) to head (0e4f66e).
⚠️ Report is 32 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14873   +/-   ##
=========================================
  Coverage     38.27%   38.27%           
  Complexity    10088    10088           
=========================================
  Files          2130     2130           
  Lines        120787   120789    +2     
  Branches      16540    16540           
=========================================
+ Hits          46227    46229    +2     
  Misses        69864    69864           
  Partials       4696     4696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. feature: analytics In-app store analytics feature: POS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants