-
Notifications
You must be signed in to change notification settings - Fork 136
[POS Orders] Beta fixes #14947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POS Orders] Beta fixes #14947
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/23.6 #14947 +/- ##
==================================================
+ Coverage 38.26% 38.29% +0.02%
- Complexity 10090 10105 +15
==================================================
Files 2137 2137
Lines 120957 121064 +107
Branches 16571 16597 +26
==================================================
+ Hits 46280 46357 +77
- Misses 69971 69986 +15
- Partials 4706 4721 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kidinov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There are still a few issues left from the CFT:
- As the background color, for some reason, is not the same on the orders list part as, for instance, products, we have to change the color of the “search button” circle background; otherwise, now it’s not visible.
- Scrolling/visibility of the orders that we just made
- Placeholder image background color
- Search icon circle background color
I think not blocking for the release, but we'd need to fix them, maybe as part of the backlog work. Wdyt?
Description
With this PR we want to merge the Historical Orders beta fixes into the 23.6 release. This includes these PRs:
Test Steps
PRs are already tested, but it would be good to double-check these scenarios, as this goes directly into the release. Please check PRs for testing steps.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.