Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Nov 13, 2025

Description

With this PR we want to merge the Historical Orders beta fixes into the 23.6 release. This includes these PRs:

Test Steps

PRs are already tested, but it would be good to double-check these scenarios, as this goes directly into the release. Please check PRs for testing steps.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@toupper toupper added this to the 23.6 ❄️ milestone Nov 13, 2025
@toupper toupper requested a review from kidinov November 13, 2025 11:29
@toupper toupper changed the title Fix/pos historical orders 23.6 beta fixes [POS Orders] Beta fixes Nov 13, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 13, 2025

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 23.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit1ba9472
Direct Downloadwoocommerce-wear-prototype-build-pr14947-1ba9472.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit1ba9472
Direct Downloadwoocommerce-prototype-build-pr14947-1ba9472.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 74.66063% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.29%. Comparing base (91ddd0f) to head (1ba9472).

Files with missing lines Patch % Lines
.../android/ui/woopos/orders/WooPosOrdersViewModel.kt 75.83% 10 Missing and 19 partials ⚠️
...ce/android/ui/woopos/orders/WooPosOrdersDetails.kt 0.00% 15 Missing ⚠️
...android/ui/woopos/orders/WooPosOrdersDataSource.kt 71.87% 2 Missing and 7 partials ⚠️
...droid/ui/woopos/orders/WooPosOrdersLoadingState.kt 0.00% 2 Missing ⚠️
...i/woopos/common/data/WooPosRetrieveOrderRefunds.kt 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/23.6   #14947      +/-   ##
==================================================
+ Coverage           38.26%   38.29%   +0.02%     
- Complexity          10090    10105      +15     
==================================================
  Files                2137     2137              
  Lines              120957   121064     +107     
  Branches            16571    16597      +26     
==================================================
+ Hits                46280    46357      +77     
- Misses              69971    69986      +15     
- Partials             4706     4721      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are still a few issues left from the CFT:

  • As the background color, for some reason, is not the same on the orders list part as, for instance, products, we have to change the color of the “search button” circle background; otherwise, now it’s not visible.
  • Scrolling/visibility of the orders that we just made
  • Placeholder image background color
  • Search icon circle background color

I think not blocking for the release, but we'd need to fix them, maybe as part of the backlog work. Wdyt?

@kidinov kidinov self-requested a review November 13, 2025 13:47
@toupper toupper merged commit 0ac5e8c into release/23.6 Nov 13, 2025
21 of 23 checks passed
@toupper toupper deleted the fix/pos-historical-orders-23.6-beta-fixes branch November 13, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants