[Woo POS][Refunds] Add Issue Refund button #15024

samiuelson · 2025-11-26T16:40:04Z

Description

This PR adds an "Issue Refund" button to the WooCommerce POS orders screen with a placeholder dialog implementation for the refund flow.

💡 The WooPosIssueRefundDialog layout is temporary. This PR aims to just open a dialog; its layout will be implemented in next PR.

💡 Feel free to remove do not merge label once the parent branch becomes trunk.

Test Steps

Verify that the Issue refund button is not showing up when the POS_REFUNDS is false.
Verify that Email Receipt button works
Verify that Issue Refund button opens a dialog with a temporary layout.

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

- Update `WooPosOrdersState` to handle dialog state for issuing refunds. - Implement `WooPosIssueRefundDialog` as a placeholder for the refund flow. - Update `WooPosOrdersDetails` to replace the "Email receipt" button with an "Issue refund" button. - Move the "Email receipt" action into a new overflow menu in the order details view. - Connect the refund button and dialog logic in `WooPosOrdersScreen` and `WooPosOrdersViewModel`.

Copilot

Pull request overview

This PR adds an "Issue Refund" button to the WooCommerce POS orders screen with a placeholder dialog implementation for the refund flow. The changes also include UI refinements to the orders loading screen.

Key Changes:

Added "Issue Refund" button to order details with dialog state management in the ViewModel
Introduced WooPosIssueRefundDialog component showing a placeholder "coming soon" message
Moved email receipt functionality to an overflow menu, replaced by the refund button as primary action
Refined loading screen spacing and padding to align with the updated order details toolbar

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
WooPosOrdersViewModel.kt	Adds dialog state management functions for opening and dismissing the issue refund dialog
WooPosOrdersState.kt	Introduces `DialogState` sealed class to track whether the issue refund dialog is visible
WooPosOrdersScreen.kt	Wires up the new refund button handlers and renders the dialog based on state; renames loading function
WooPosOrdersLoadingScreen.kt	Updates padding and spacing to match the new toolbar layout with status bar insets
WooPosOrdersDetails.kt	Replaces email receipt button with issue refund button and adds overflow menu for email receipt
WooPosIssueRefundDialog.kt	New dialog component displaying placeholder UI for the upcoming refund functionality

Comments suppressed due to low confidence (1)

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersLoadingScreen.kt:169

Adding padding(vertical = WooPosSpacing.Small.value) after clip() applies padding outside the clipped region, which won't affect the shimmer box's appearance. If the intent is to add internal padding, it should be placed before the clip() modifier. If external spacing is needed, consider using Spacer or margin-like approaches instead.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosIssueRefundDialog.kt

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

wpmobilebot · 2025-11-26T16:45:38Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`2001de8`
	Direct Download	`woocommerce-wear-prototype-build-pr15024-2001de8.apk`

wpmobilebot · 2025-11-26T17:13:25Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`2001de8`
	Direct Download	`woocommerce-prototype-build-pr15024-2001de8.apk`

codecov-commenter · 2025-11-26T17:37:39Z

Codecov Report

❌ Patch coverage is 13.04348% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.58%. Comparing base (11b9108) to head (b832c4d).

Files with missing lines	Patch %	Lines
...ndroid/ui/woopos/orders/WooPosIssueRefundDialog.kt	0.00%	45 Missing ⚠️
...ce/android/ui/woopos/orders/WooPosOrdersDetails.kt	0.00%	35 Missing ⚠️

Additional details and impacted files

@@                           Coverage Diff                            @@
##             pos-orders-fix-status-bar-handling   #15024      +/-   ##
========================================================================
- Coverage                                 38.59%   38.58%   -0.02%     
- Complexity                                10293    10299       +6     
========================================================================
  Files                                      2160     2161       +1     
  Lines                                    122503   122591      +88     
  Branches                                  16887    16900      +13     
========================================================================
+ Hits                                      47285    47297      +12     
- Misses                                    70419    70495      +76     
  Partials                                   4799     4799

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…d-the-issue-refund-button

kidinov

👋 @samiuelson

The button is visible even when FF is off - so not finished functionality will be released?
I am not sure about the design of the button—in Figma there is no more overflow menu without an email button at all 🤔

- Propagate the `POS_REFUNDS` feature flag status through `WooPosOrdersState` and `WooPosOrdersViewModel`. - Update `WooPosOrdersDetails` to conditionally render the "Issue Refund" button and overflow menu. - Show a direct "Email Receipt" button when refunds are disabled.

samiuelson · 2025-11-27T09:22:03Z

Thanks for the review, @kidinov!

The button is visible even when FF is off - so not finished functionality will be released?

I was convinced I've committed that 🤦 Missing commit pushed: f41a4ac

I am not sure about the design of the button—in Figma there is no more overflow menu without an email button at all 🤔

This UX pattern proposal comes from a designer:

Discussion: p1764073551626429/1763399395.564619-slack-C070SJRA8DP.
Docs: pdfdoF-7Av-p2

dangermattic · 2025-11-27T09:27:38Z

	1 Error
🚫	This PR is tagged with `status: do not merge` label(s).

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

kidinov · 2025-11-27T13:30:33Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersDetails.kt

-                text = stringResource(R.string.woopos_orders_email_receipt),
-                onClick = { onEmailReceiptButtonClicked(details.id) },
-            )
+            if (isRefundsEnabled) {


I think it's not a good state model. It looks like we need to expose a list of buttons to the view, where the first one will be visible while the rest will be hidden in the overflow menu. Currently we kinda hardcode the priority in the view, while it's highly likely it will depend on the state of the specific order

With the list of buttons, we can pass events that each specific button emits when clicked, just like we do on the home page. Eventually, we’ll have numerous actions that can be performed on the orders.

kidinov

I left a couple of comments but they can be implemented as a seprate PR

Also:

The floating menu button doesn't match the design

- Replace `isRefundsEnabled` boolean in `WooPosOrdersState` with a list of `OrderAction` objects. - Introduce `OrderAction` sealed interface with `IssueRefund` and `EmailReceipt` types. - Update `WooPosOrdersViewModel` to determine available actions based on feature flags. - Adjust `WooPosOrdersDetails` UI to render the first action as a button and remaining actions in the overflow menu.

wpmobilebot · 2025-11-28T11:50:54Z

Version 23.8 has now entered code-freeze, so the milestone of this PR has been updated to 23.9.

kidinov · 2025-12-01T06:51:32Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersDetails.kt

    details: OrderDetailsViewState.Computed.Details,
-    onEmailReceiptButtonClicked: (Long) -> Unit
+    actions: List<OrderAction>,
+    onEmailReceiptButtonClicked: (Long) -> Unit,


Not sure if it's the final state or still WIP, but this is not something that is driven by the VM as you have to pass hardcoded click listeners here and everywhere instead of calling one onUIEvent that accepts events that are part of the “actions”. Also, why is OrderAction not part of the whole state but a separate class?

samiuelson requested a review from Copilot November 26, 2025 16:40

Copilot started reviewing on behalf of samiuelson November 26, 2025 16:40 View session

Copilot finished reviewing on behalf of samiuelson November 26, 2025 16:42

Copilot AI reviewed Nov 26, 2025

View reviewed changes

samiuelson added 2 commits November 26, 2025 17:46

Add unit tests for Issue Refund dialog in WooPosOrdersViewModel

07b4c38

Satisfy detekt's complaints

59fdd82

samiuelson changed the base branch from trunk to pos-orders-fix-status-bar-handling November 26, 2025 17:06

samiuelson added this to the 23.8 milestone Nov 26, 2025

samiuelson added Android type: task An internally driven task. feature: POS and removed Android labels Nov 26, 2025

samiuelson requested a review from kidinov November 26, 2025 17:47

samiuelson marked this pull request as ready for review November 26, 2025 17:47

Merge branch 'pos-orders-fix-status-bar-handling' into woomob-1801-ad…

b832c4d

…d-the-issue-refund-button

kidinov self-assigned this Nov 27, 2025

kidinov reviewed Nov 27, 2025

View reviewed changes

samiuelson added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Nov 27, 2025

kidinov reviewed Nov 27, 2025

View reviewed changes

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt Outdated Show resolved Hide resolved

kidinov reviewed Nov 27, 2025

View reviewed changes

kidinov self-requested a review November 27, 2025 14:19

kidinov approved these changes Nov 27, 2025

View reviewed changes

Update DropdownMenu background color in WooPosOrdersDetails

2001de8

wpmobilebot modified the milestones: 23.8, 23.9 Nov 28, 2025

kidinov reviewed Dec 1, 2025

View reviewed changes

[Woo POS][Refunds] Add Issue Refund button #15024

Are you sure you want to change the base?

[Woo POS][Refunds] Add Issue Refund button #15024

Conversation

samiuelson commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Steps

Images/gif

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpmobilebot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kidinov left a comment

Choose a reason for hiding this comment

Uh oh!

samiuelson commented Nov 27, 2025

Uh oh!

dangermattic commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kidinov Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

kidinov left a comment

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Nov 28, 2025

Uh oh!

kidinov Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

samiuelson commented Nov 26, 2025 •

edited

Loading

wpmobilebot commented Nov 26, 2025 •

edited

Loading

wpmobilebot commented Nov 26, 2025 •

edited

Loading

codecov-commenter commented Nov 26, 2025 •

edited

Loading

dangermattic commented Nov 27, 2025 •

edited

Loading