Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Dec 1, 2025

Closes: AINFRA-548: Migrate ThemeModel

Description

Test Steps

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

wzieba and others added 3 commits December 1, 2025 12:34
- Convert all classes and methods to Kotlin syntax
- Use @JvmField for properties accessed from Java code
- Maintain exact same behavior and API
- All tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
- Convert ThemeModel to Room entity with composite primary key (siteId, themeId, isWpComTheme)
- Create ThemeDao with direct @upsert exposure following OrderStatusDao pattern
- Remove ThemeSqlUtils and move business logic to ThemeStore
- Add LocalIdConverter for Room type conversion
- Add comprehensive ThemeDaoTest with 13 test cases
- Rewrite ThemeStoreUnitTest from Java to Kotlin
- Update WPAndroidDatabase to version 31 with AutoMigration
- Use site.localId() instead of LocalId(site.id)
- Use runBlocking without dispatcher to preserve threading behavior

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@dangermattic
Copy link
Collaborator

1 Error
🚫 Please add tests for class LocalIdConverter (or add unit-tests-exemption label to ignore this).
1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

🤖 Test Failure Analysis

Your tests failed. Claude has analyzed the failures - check the annotation for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants