-
Notifications
You must be signed in to change notification settings - Fork 136
[WOOMOB-1647] Handle CardReaderStatus Reconnecting flow #15047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: woomob-1647-pr1-version-bump-and-breaking-changes
Are you sure you want to change the base?
[WOOMOB-1647] Handle CardReaderStatus Reconnecting flow #15047
Conversation
…-breaking-changes' into woomob-1647-pr2-handle-reconnecting-status
🤖 Generated with [Claude Code](https://claude.com/claude-code)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Generated by 🚫 Danger |
Project dependencies changeslist! Upgraded Dependencies
androidx.datastore:datastore:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-android:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-core:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-core-android:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-core-okio:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-core-okio-jvm:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-preferences:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-preferences-android:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-preferences-core:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-preferences-core-android:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-preferences-external-protobuf:1.2.0, (changed from 1.1.7)
androidx.datastore:datastore-preferences-proto:1.2.0, (changed from 1.1.7)tree +--- com.google.firebase:firebase-messaging -> 25.0.1
| \--- com.google.firebase:firebase-common:22.0.1
-| \--- androidx.datastore:datastore-preferences:1.1.7
-| \--- androidx.datastore:datastore-preferences-android:1.1.7
-| +--- androidx.datastore:datastore:1.1.7
-| | \--- androidx.datastore:datastore-android:1.1.7
-| | +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
-| | +--- androidx.datastore:datastore-core:1.1.7
-| | | \--- androidx.datastore:datastore-core-android:1.1.7
-| | | +--- androidx.annotation:annotation:1.7.0 -> 1.9.1 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.22 -> 2.2.21
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.21 (*)
-| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-| | | +--- androidx.datastore:datastore:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-core-okio:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences-core:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences-proto:1.1.7 (c)
-| | | \--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7 (c)
-| | +--- androidx.datastore:datastore-core-okio:1.1.7
-| | | \--- androidx.datastore:datastore-core-okio-jvm:1.1.7
-| | | +--- androidx.datastore:datastore-core:1.1.7 (*)
-| | | +--- com.squareup.okio:okio:3.4.0 -> 3.16.4
-| | | | \--- com.squareup.okio:okio-jvm:3.16.4
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.20 -> 2.2.21 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.21 (*)
-| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-| | | +--- androidx.datastore:datastore:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-core:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences-core:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences-proto:1.1.7 (c)
-| | | \--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7 (c)
-| | +--- com.squareup.okio:okio:3.4.0 -> 3.16.4 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.21 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-| | +--- androidx.datastore:datastore-core:1.1.7 (c)
-| | +--- androidx.datastore:datastore-core-okio:1.1.7 (c)
-| | +--- androidx.datastore:datastore-preferences:1.1.7 (c)
-| | +--- androidx.datastore:datastore-preferences-core:1.1.7 (c)
-| | +--- androidx.datastore:datastore-preferences-proto:1.1.7 (c)
-| | \--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7 (c)
-| +--- androidx.datastore:datastore-preferences-core:1.1.7
-| | \--- androidx.datastore:datastore-preferences-core-android:1.1.7
-| | +--- androidx.datastore:datastore-core:1.1.7 (*)
-| | +--- androidx.datastore:datastore-core-okio:1.1.7 (*)
-| | +--- androidx.datastore:datastore-preferences-proto:1.1.7
-| | | +--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7
-| | | | +--- androidx.datastore:datastore:1.1.7 (c)
-| | | | +--- androidx.datastore:datastore-core:1.1.7 (c)
-| | | | +--- androidx.datastore:datastore-core-okio:1.1.7 (c)
-| | | | +--- androidx.datastore:datastore-preferences:1.1.7 (c)
-| | | | +--- androidx.datastore:datastore-preferences-core:1.1.7 (c)
-| | | | \--- androidx.datastore:datastore-preferences-proto:1.1.7 (c)
-| | | +--- androidx.datastore:datastore:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-core:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-core-okio:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences:1.1.7 (c)
-| | | +--- androidx.datastore:datastore-preferences-core:1.1.7 (c)
-| | | \--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7 (c)
-| | +--- com.squareup.okio:okio:3.4.0 -> 3.16.4 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.21 (*)
-| | +--- androidx.datastore:datastore:1.1.7 (c)
-| | +--- androidx.datastore:datastore-core:1.1.7 (c)
-| | +--- androidx.datastore:datastore-core-okio:1.1.7 (c)
-| | +--- androidx.datastore:datastore-preferences:1.1.7 (c)
-| | +--- androidx.datastore:datastore-preferences-proto:1.1.7 (c)
-| | \--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7 (c)
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.21 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-| +--- androidx.datastore:datastore:1.1.7 (c)
-| +--- androidx.datastore:datastore-preferences-core:1.1.7 (c)
-| +--- androidx.datastore:datastore-core:1.1.7 (c)
-| +--- androidx.datastore:datastore-core-okio:1.1.7 (c)
-| +--- androidx.datastore:datastore-preferences-proto:1.1.7 (c)
-| \--- androidx.datastore:datastore-preferences-external-protobuf:1.1.7 (c)
+| \--- androidx.datastore:datastore-preferences:1.1.7 -> 1.2.0
+| \--- androidx.datastore:datastore-preferences-android:1.2.0
+| +--- androidx.datastore:datastore:1.2.0
+| | \--- androidx.datastore:datastore-android:1.2.0
+| | +--- androidx.annotation:annotation:1.9.1 (*)
+| | +--- androidx.datastore:datastore-core:1.2.0
+| | | \--- androidx.datastore:datastore-core-android:1.2.0
+| | | +--- androidx.annotation:annotation:1.9.1 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.21 (*)
+| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0 -> 1.10.2 (*)
+| | | +--- androidx.datastore:datastore:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-core-okio:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences-core:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences-proto:1.2.0 (c)
+| | | \--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0 (c)
+| | +--- androidx.datastore:datastore-core-okio:1.2.0
+| | | \--- androidx.datastore:datastore-core-okio-jvm:1.2.0
+| | | +--- androidx.datastore:datastore-core:1.2.0 (*)
+| | | +--- com.squareup.okio:okio:3.9.1 -> 3.16.4
+| | | | \--- com.squareup.okio:okio-jvm:3.16.4
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.20 -> 2.2.21 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.21 (*)
+| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0 -> 1.10.2 (*)
+| | | +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3
+| | | | \--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.7.3
+| | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.7.3 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.20 -> 2.2.21 (*)
+| | | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+| | | +--- androidx.datastore:datastore:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-core:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences-core:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences-proto:1.2.0 (c)
+| | | \--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0 (c)
+| | +--- com.squareup.okio:okio:3.9.1 -> 3.16.4 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.21 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0 -> 1.10.2 (*)
+| | +--- androidx.datastore:datastore-core:1.2.0 (c)
+| | +--- androidx.datastore:datastore-core-okio:1.2.0 (c)
+| | +--- androidx.datastore:datastore-preferences:1.2.0 (c)
+| | +--- androidx.datastore:datastore-preferences-core:1.2.0 (c)
+| | +--- androidx.datastore:datastore-preferences-proto:1.2.0 (c)
+| | \--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0 (c)
+| +--- androidx.datastore:datastore-preferences-core:1.2.0
+| | \--- androidx.datastore:datastore-preferences-core-android:1.2.0
+| | +--- androidx.datastore:datastore-core:1.2.0 (*)
+| | +--- androidx.datastore:datastore-core-okio:1.2.0 (*)
+| | +--- androidx.datastore:datastore-preferences-proto:1.2.0
+| | | +--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0
+| | | | +--- androidx.datastore:datastore:1.2.0 (c)
+| | | | +--- androidx.datastore:datastore-core:1.2.0 (c)
+| | | | +--- androidx.datastore:datastore-core-okio:1.2.0 (c)
+| | | | +--- androidx.datastore:datastore-preferences:1.2.0 (c)
+| | | | +--- androidx.datastore:datastore-preferences-core:1.2.0 (c)
+| | | | \--- androidx.datastore:datastore-preferences-proto:1.2.0 (c)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.21 (*)
+| | | +--- androidx.datastore:datastore:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-core:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-core-okio:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences:1.2.0 (c)
+| | | +--- androidx.datastore:datastore-preferences-core:1.2.0 (c)
+| | | \--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0 (c)
+| | +--- com.squareup.okio:okio:3.9.1 -> 3.16.4 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.21 (*)
+| | +--- androidx.datastore:datastore:1.2.0 (c)
+| | +--- androidx.datastore:datastore-core:1.2.0 (c)
+| | +--- androidx.datastore:datastore-core-okio:1.2.0 (c)
+| | +--- androidx.datastore:datastore-preferences:1.2.0 (c)
+| | +--- androidx.datastore:datastore-preferences-proto:1.2.0 (c)
+| | \--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0 (c)
+| +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.21 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0 -> 1.10.2 (*)
+| +--- androidx.datastore:datastore:1.2.0 (c)
+| +--- androidx.datastore:datastore-preferences-core:1.2.0 (c)
+| +--- androidx.datastore:datastore-core:1.2.0 (c)
+| +--- androidx.datastore:datastore-core-okio:1.2.0 (c)
+| +--- androidx.datastore:datastore-preferences-proto:1.2.0 (c)
+| \--- androidx.datastore:datastore-preferences-external-protobuf:1.2.0 (c)
-+--- androidx.datastore:datastore-preferences:1.1.7 (*)
++--- androidx.datastore:datastore-preferences:1.2.0 (*)
-+--- androidx.datastore:datastore:1.1.7 (*)
++--- androidx.datastore:datastore:1.2.0 (*)
+--- project :libs:fluxc
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.2.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.2.21
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.21 (*)
+--- project :libs:cardreader
| \--- com.stripe:stripeterminal-core:5.0.0
| \--- com.stripe:stripeterminal-internal-common:5.0.0
-| \--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3 -> 1.7.3
-| \--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.7.3
-| +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.7.3 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.20 -> 2.2.21 (*)
-| \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+| \--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3 -> 1.7.3 (*)
\--- org.wordpress:mediapicker:0.3.4
- \--- androidx.datastore:datastore-preferences:1.0.0 -> 1.1.7 (*)
+ \--- androidx.datastore:datastore-preferences:1.0.0 -> 1.2.0 (*) |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
3232f07 to
96d7194
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## woomob-1647-pr1-version-bump-and-breaking-changes #15047 +/- ##
=======================================================================================
- Coverage 38.61% 38.58% -0.03%
- Complexity 10311 10312 +1
=======================================================================================
Files 2163 2163
Lines 122674 122737 +63
Branches 16935 16943 +8
=======================================================================================
- Hits 47366 47363 -3
- Misses 70501 70562 +61
- Partials 4807 4812 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
malinajirka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I noticed the toolbar is duplicated on one of your screenshots (and many other screens). Seems like the Stripe SDK transitively updates the material library to the broken version we reverted a couple weeks ago. Is this on your radar?
|
@malinajirka Thanks for the review
Yes! I noticed this as well and confirmed the reason behind that. We have a ticket on Kiwi already to handle this, so we will be blocked from merging this until it's resolved |
WOOMOB-1647
Description
This PR implements proper handling of the card reader reconnecting status introduced in Stripe SDK 5.0.0. When the SDK automatically attempts to reconnect to a card reader, users now see a "Reconnecting…" status message in the UI with cancelation option
Changes:
CardReaderStatus.Reconnectingto the sealed classBluetoothReaderListenerImplandTapToPayReaderListenerImplTest Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.