Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Dec 2, 2025

Description

This fixes a padding issue that occurs when navigating to filter pages after tapping the search field.

The unwanted top gap was caused by nested Scaffolds, where the inner Scaffold was reapplying system window insets on top of the parent's padding. This is resolved by setting the inner Scaffold's contentWindowInsets to zero, preventing the double application of safe area insets.

Test Steps

I suggest you try this on trunk first.
To reproduce the issue:

  1. Log in with a CIAB store.
  2. Go to Bookings.
  3. Tap the Search field.
  4. While the text cursor is still active on the search field, tap the Filters button.
  5. Tap Team Members.

Images/gif

Before After
before-team after-team
before-date after-date
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit67217f5
Direct Downloadwoocommerce-wear-prototype-build-pr15052-67217f5.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit67217f5
Direct Downloadwoocommerce-prototype-build-pr15052-67217f5.apk

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.60%. Comparing base (020f488) to head (67217f5).

Files with missing lines Patch % Lines
.../ui/bookings/filter/datetime/DateTimeFilterPage.kt 0.00% 2 Missing ⚠️
...s/filter/teammember/BookingTeamMemberFilterPage.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #15052      +/-   ##
============================================
- Coverage     38.61%   38.60%   -0.01%     
+ Complexity    10312    10311       -1     
============================================
  Files          2163     2163              
  Lines        122674   122676       +2     
  Branches      16934    16934              
============================================
- Hits          47366    47363       -3     
- Misses        70503    70507       +4     
- Partials       4805     4806       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants