[CIAB: POS] Hide collect payment button for refunded bookings

[samiuelson]

Description

WOOMOB-2285

When a booking is in "Cancelled" status with a "Refunded" payment status, the "Collect Payment" button was still being shown in the POS booking detail screen. This PR hides the collect payment button for refunded bookings, since collecting payment on an already-refunded booking doesn't make sense.

Adds an isBookingRefunded check alongside the existing isBookingPaid check so that collectPaymentLabel is set to null when the booking is both cancelled and refunded.

Test Steps

1. Open a POS booking that is Cancelled with Refunded payment status
2. Verify the "Collect Payment" button is not shown
3. Open a POS booking that is Cancelled but not refunded
4. Verify the "Collect Payment" button is still shown
5. Open a paid/completed booking and verify collect payment is still hidden as before

Images/gif

Cancelled && Refunded

Cancelled

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Build Number	727
	Version	24.1-rc-3
	Application ID	com.woocommerce.android.prealpha
	Commit	c9e122f
	Installation URL	0r5tma1jkqgbg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.29%. Comparing base (ab7c42b) to head (c9e122f).
⚠️ Report is 21 commits behind head on trunk.

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #15402   +/-   ##
=========================================
  Coverage     39.29%   39.29%           
- Complexity    10977    10981    +4     
=========================================
  Files          2238     2238           
  Lines        127540   127545    +5     
  Branches      17802    17803    +1     
=========================================
+ Hits          50113    50120    +7     
+ Misses        72318    72316    -2     
  Partials       5109     5109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kidinov]

Small naming suggestion: isBookingPaid / isBookingRefunded sound like they only check the booking status, but they actually check a combination of booking status + payment status. This is a bit misleading.

Proposal:

  // Methods
  isBookingPaid(...)    → hasPaymentBeenCollected(...)
  isBookingRefunded(...) → hasPaymentBeenRefunded(...)

  // Local variables
  val isPaid = ...      → val isPaymentCollected = ...
  val isRefunded = ...  → val isPaymentRefunded = ...

[kidinov]

@samiuelson thinking further -

Suggestion: instead of two boolean methods (isBookingPaid + isBookingRefunded), we could use a single method that returns an enum. The two booleans are really three mutually exclusive states: paid, refunded, or unpaid.

private enum class PaymentState { Paid, Refunded, Unpaid }            
                                                                                                                                                                                                                                                                                                                           
private fun resolvePaymentState(                                                                                                                                                                                                                                                                                           
    bookingStatus: BookingEntity.Status,
    paymentStatus: PaymentStatus,
): PaymentState = when (bookingStatus) {
    BookingEntity.Status.Paid, BookingEntity.Status.Complete -> PaymentState.Paid
    BookingEntity.Status.Cancelled -> when (paymentStatus) {
        PaymentStatus.PAID -> PaymentState.Paid
        PaymentStatus.REFUNDED -> PaymentState.Refunded
        else -> PaymentState.Unpaid
    }
    else -> PaymentState.Unpaid
}

Then usage becomes:

// actions list
val paymentState = resolvePaymentState(booking.status, paymentStatus)
if (paymentState == PaymentState.Paid) {
    add(WooPosBookingsState.BookingAction.IssueRefund(booking.orderId))
}

// payment section
val paymentState = resolvePaymentState(booking.status, paymentStatus)
paidWithLabel = if (paymentState == PaymentState.Paid) paymentInfo?.paymentMethodTitle else null,
collectPaymentLabel = if (paymentState == PaymentState.Unpaid) totalAmount else null,

This removes the two boolean methods, makes the states explicit, and avoids the !isPaid && !isRefunded check.

[kidinov]

LGTM - I left a code improvement suggestion