Skip to content

Comments

[CIAB:POS] Set View Order as primary action in overflow menu#15406

Open
kidinov wants to merge 1 commit intotrunkfrom
woomob-2292-pos-bookings-set-view-order-as-primary-action-in-overflow
Open

[CIAB:POS] Set View Order as primary action in overflow menu#15406
kidinov wants to merge 1 commit intotrunkfrom
woomob-2292-pos-bookings-set-view-order-as-primary-action-in-overflow

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented Feb 20, 2026

Closes: WOOMOB-2292

Description

The order and booking detail screens had duplicate overflow menu implementations. This PR extracts a shared WooPosOverflowMenu component and sets "View Order" as the primary action (displayed as a button outside the overflow) in booking details.

Also cleaned up the API by combining two separate nullable parameters (primaryActionLabel + onPrimaryActionClick) into a single nullable WooPosOverflowPrimaryAction data class.

Testing instructions

  1. Open POS and complete a booking order
  2. Open booking details - verify "View Order" appears as a button (primary action) and other actions are in the overflow menu
  3. Open a regular order details - verify the primary action button and overflow menu still work
  4. Tap each menu item and verify it dismisses the dropdown and triggers the correct action
02-20--14-36.mp4

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 20, 2026

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kidinov kidinov changed the title POS: Extract shared WooPosOverflowMenu with primary action support POS Bookings: Set View Order as primary action in overflow menu Feb 20, 2026
@kidinov kidinov added this to the 24.2 milestone Feb 20, 2026
@kidinov kidinov requested a review from samiuelson February 20, 2026 13:40
@kidinov kidinov changed the title POS Bookings: Set View Order as primary action in overflow menu [CIAB:POS] Set View Order as primary action in overflow menu Feb 20, 2026
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Build Number727
Version24.1-rc-3
Application IDcom.woocommerce.android.prealpha
Commitdc579a2
Installation URL4cq2mnfur9goo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.30%. Comparing base (61bc1a8) to head (dc579a2).
⚠️ Report is 16 commits behind head on trunk.

Files with missing lines Patch % Lines
...s/common/composeui/component/WooPosOverflowMenu.kt 0.00% 56 Missing ⚠️
...ui/woopos/bookings/details/WooPosBookingDetails.kt 0.00% 35 Missing ⚠️
...oid/ui/woopos/orders/details/WooPosOrderDetails.kt 0.00% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #15406      +/-   ##
============================================
- Coverage     39.30%   39.30%   -0.01%     
- Complexity    10982    10983       +1     
============================================
  Files          2239     2240       +1     
  Lines        127602   127608       +6     
  Branches      17820    17826       +6     
============================================
  Hits          50158    50158              
- Misses        72322    72328       +6     
  Partials       5122     5122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants