[CIAB:POS] Set View Order as primary action in overflow menu#15406
Open
[CIAB:POS] Set View Order as primary action in overflow menu#15406
Conversation
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15406 +/- ##
============================================
- Coverage 39.30% 39.30% -0.01%
- Complexity 10982 10983 +1
============================================
Files 2239 2240 +1
Lines 127602 127608 +6
Branches 17820 17826 +6
============================================
Hits 50158 50158
- Misses 72322 72328 +6
Partials 5122 5122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes: WOOMOB-2292
Description
The order and booking detail screens had duplicate overflow menu implementations. This PR extracts a shared
WooPosOverflowMenucomponent and sets "View Order" as the primary action (displayed as a button outside the overflow) in booking details.Also cleaned up the API by combining two separate nullable parameters (
primaryActionLabel+onPrimaryActionClick) into a single nullableWooPosOverflowPrimaryActiondata class.Testing instructions
02-20--14-36.mp4