[WOOMOB-1438] Route media requests through WooMediaNetwork for app passwords#15534
Closed
hichamboushaba wants to merge 6 commits intotrunkfrom
Closed
[WOOMOB-1438] Route media requests through WooMediaNetwork for app passwords#15534hichamboushaba wants to merge 6 commits intotrunkfrom
hichamboushaba wants to merge 6 commits intotrunkfrom
Conversation
hichamboushaba
added
type: task
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private fun launchUpload(site: SiteModel, media: MediaModel) { | ||
| val uploadJob = coroutineEngine.launch(AppLog.T.MEDIA, this, "Uploading media") { | ||
| try { | ||
| when (site.origin) { |
Check warning
Code scanning / Android Lint
Missing @IntDef in Switch Warning
Extract shared Jetpack guard, add GeneralSecurityException handling matching WooNetwork, add logging for failed app-password requests, and throw on unsupported site origins. Remove unused FluxCCrashLogger from MediaStore. Expand test suite from 5 to 15 cases.
hichamboushaba
force-pushed
the
issue/WOOMOB-1438-migrate-media-endpoints-to-app-passwords
branch
from
0fbc09e to
45c1505
Compare
Member
Author
|
Closing in favor of two smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes WOOMOB-1438
The
/mediaendpoints in FluxC still use old Java code that bypassesWooNetwork, so they weren't migrated to application passwords with the rest of the endpoints. This PR introducesWooMediaNetwork, a routing layer that:JetpackApplicationPasswordsErrorHandlerMediaStoreby replacing direct client references with delegation toWooMediaNetworkstatusCodeandapiErrorCodeonMediaErrorso the fallback logic can reconstruct properWPAPINetworkErrorsTest Steps
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.