[TTP] Handle VM death when TTP activity in foreground #8967
+112
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidinov
added
the
feature: mobile payments
Collaborator
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
kidinov
requested review from
AnirudhBhat and
samiuelson
and removed request for
samiuelson
1 task
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #8967 +/- ##
============================================
+ Coverage 43.52% 43.54% +0.01%
- Complexity 4057 4063 +6
============================================
Files 841 841
Lines 44101 44115 +14
Branches 5756 5758 +2
============================================
+ Hits 19196 19210 +14
Misses 23213 23213
Partials 1692 1692
☔ View full report in Codecov by Sentry. |
kidinov
added
the
status: do not merge
…and-reconnection-2
kidinov
removed
the
status: do not merge
…and-reconnection-2
AnirudhBhat
approved these changes
May 25, 2023
Contributor
AnirudhBhat
left a comment
AnirudhBhat
left a comment
There was a problem hiding this comment.
LGTM! I've left couple of non-blocking comment.
...test/kotlin/com/woocommerce/android/ui/payments/cardreader/CardReaderPaymentViewModelTest.kt
Show resolved
Hide resolved
…t emitted when the TTP payment is not in progress and the card reader is connected, and that payment collection doesn't start when the `AppKilledWhileInBackground` state is emitted.
kidinov
deleted the
8140-handle-built-in-reader-disconnections-and-reconnection-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8140
Description
This PR brings another error that's shown when Activity and VM are killed during TTP activity being in the foreground. Also, it adds tracking of this situation so we can determine if this is not an ideal solution and needs to be improved
Testing instructions
Test TTP, IPP (including refund) with "don't keep activity" dev option ON and OFF
When it's on, TTP will fail with the screen that explains that this happened
Images/gif
05-05--15-56.mp4
RELEASE-NOTES.txtif necessary.