Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented May 10, 2023

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 10, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch coverage: 25.71% and no project coverage change.

Comparison is base (4d9f86d) 43.82% compared to head (8ef3651) 43.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##              trunk    #9001    +/-   ##
==========================================
  Coverage     43.82%   43.82%            
- Complexity     4154     4162     +8     
==========================================
  Files           843      845     +2     
  Lines         44511    44624   +113     
  Branches       5827     5850    +23     
==========================================
+ Hits          19505    19555    +50     
- Misses        23309    23364    +55     
- Partials       1697     1705     +8     
Impacted Files Coverage Δ
.../kotlin/com/woocommerce/android/AppPrefsWrapper.kt 0.00% <0.00%> (ø)
...src/main/kotlin/com/woocommerce/android/AppUrls.kt 0.00% <ø> (ø)
...tlin/com/woocommerce/android/ui/icons/OpenInNew.kt 0.00% <0.00%> (ø)
...in/com/woocommerce/android/ui/main/MainActivity.kt 0.00% <ø> (ø)
...ocommerce/android/ui/main/MainActivityViewModel.kt 61.23% <0.00%> (-2.14%) ⬇️
...erce/android/ui/prefs/PrivacySettingsRepository.kt 0.00% <0.00%> (ø)
...mmerce/android/ui/prefs/RequestedAnalyticsValue.kt 0.00% <0.00%> (ø)
.../ui/prefs/privacy/banner/PrivacyBannerViewModel.kt 0.00% <0.00%> (ø)
...tlin/com/woocommerce/android/util/ActivityUtils.kt 0.00% <ø> (ø)
...merce/android/analytics/AnalyticsTrackerWrapper.kt 16.00% <14.28%> (+8.30%) ⬆️
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wzieba wzieba added this to the 13.6 milestone May 10, 2023
@wzieba wzieba removed this from the 13.7 milestone May 18, 2023
wzieba and others added 21 commits May 18, 2023 11:50
By using single source of truth we decrease risk of invalid state and
simplify the codebase.
…_on_privacy_screen

Privacy Screen: Fix retry button
…link

Privacy Screen: update copy and links
…nalytics

Add Privacy Banner analytics events
@wzieba wzieba marked this pull request as ready for review May 26, 2023 06:17
@peril-woocommerce
Copy link

peril-woocommerce bot commented May 26, 2023

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the test plan and this is ready to be merged! 🎉

@Ecarrion Ecarrion enabled auto-merge May 26, 2023 15:13
@Ecarrion Ecarrion merged commit a6a0478 into trunk May 26, 2023
@Ecarrion Ecarrion deleted the feature/new_privacy_screen branch May 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants