-
Notifications
You must be signed in to change notification settings - Fork 136
[Feature] New privacy screen #9001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…edesign Privacy screen redesign
…gn' into issue/8938_more_privacy_options_row
…row' into issue/8939_support_link_actions
…_analytics_switch_tracking
|
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #9001 +/- ##
==========================================
Coverage 43.82% 43.82%
- Complexity 4154 4162 +8
==========================================
Files 843 845 +2
Lines 44511 44624 +113
Branches 5827 5850 +23
==========================================
+ Hits 19505 19555 +50
- Misses 23309 23364 +55
- Partials 1697 1705 +8
☔ View full report in Codecov by Sentry. |
…. Show error otherwise
…ages with retry option if API failed.
…row' into issue/8939_support_link_actions
…ions_row Add More Privacy Options row
By using single source of truth we decrease risk of invalid state and simplify the codebase.
…_on_privacy_screen Privacy Screen: Fix retry button
…s, mark privacy banner as seen
…rivacy Banner as seen
Privacy Banner: handle Settings CTA
…link Privacy Screen: update copy and links
…nalytics Add Privacy Banner analytics events
Generated by 🚫 dangerJS |
Ecarrion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run the test plan and this is ready to be merged! 🎉
Description
Feature branch for the new Privacy Screen. Contains code from:
Testing instructions
Perform internal test plan
RELEASE-NOTES.txtif necessary.