Skip to content

Add new prop to ORDER_CREATION_SUCCESS event #9075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2023
Merged

Add new prop to ORDER_CREATION_SUCCESS event #9075

merged 1 commit into from
May 26, 2023

Conversation

@samiuelson
Copy link
Contributor

@samiuelson samiuelson commented May 19, 2023 •
edited
Loading

The goal of this PR is to enable tracking of the number of discount coupons added to an order.

Description

Added "coupons_count" property to the ORDER_CREATION_SUCCESS event.

Testing instructions

  1. Create an order with a (valid) coupon
  2. Verify ORDER_CREATION_SUCCESS is tracked and contains coupons_count = 1 property.

Images/gif

Zrzut ekranu 2023-05-19 o 15 13 59
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@samiuelson samiuelson added category: tracks Related to analytics, including Tracks Events. feature: order creation Related to the Order Creation feature labels May 19, 2023
@samiuelson samiuelson added this to the 13.8 milestone May 19, 2023
@samiuelson samiuelson requested a review from AnirudhBhat May 19, 2023 13:15
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 19, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@AnirudhBhat AnirudhBhat self-assigned this May 26, 2023
AnirudhBhat
AnirudhBhat approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat merged commit 26e5d20 into trunk May 26, 2023
@AnirudhBhat AnirudhBhat deleted the order-creation-analytics-update branch May 26, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AnirudhBhat AnirudhBhat AnirudhBhat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AnirudhBhat AnirudhBhat

Labels

category: tracks Related to analytics, including Tracks Events. feature: order creation Related to the Order Creation feature

Projects

None yet

Milestone

13.8

Development

Successfully merging this pull request may close these issues.

4 participants

@samiuelson @wpmobilebot @AnirudhBhat