-
Notifications
You must be signed in to change notification settings - Fork 136
Activate: Store creation incomplete notification #9094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ore-creation-incomplete
|
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
| } | ||
|
|
||
| // No need to display a notification to complete store creation anymore | ||
| localNotificationScheduler.cancelScheduledNotification(STORE_CREATION_INCOMPLETE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome that you realized this use case!
| observeBottomBarState() | ||
| } | ||
|
|
||
| private fun shortcutOpenStoreCreation(storeName: String?) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: maybe rename to openShortcutToStoreCreation() to follow "use verb for function name".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that there's already existing functions that use the same shortcutXXX() pattern, so feel free to ignore the above to keep with the pattern instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just copied what was already there, otherwise I'd agree 💯
hafizrahman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my test. Awesome work! I checked the commit one by one to get a better understanding how setting up a scheduled local notification will work, and things look good to me.
I left a non-blocking comment so feel free to merge after reading that and fixing conflicts.
|
Thanks @hafizrahman! |
Generated by 🚫 dangerJS |
Fixes #9088, a subtask of #8999.
This PR schedules a notification 24 hours after a store name is entered during store creation and then it's abandoned without completion. When the notification is tapped, the store creation is restarted with the original name pre-filled.
device-2023-05-24-010103.webm
To test:
Test 1
Test 2