Skip to content

Conversation

@kidinov
Copy link
Contributor

@kidinov kidinov commented May 24, 2023

Closes: #9089

Description

The PR sets maximum screen brightness when we show generated QR

Testing instructions

  • Collect payment via scan to pay payment method
  • Notice that the brightness goes maximum on that screen, and returns back when a user leaves/hides it

Images/gif

Not possible to show on a video

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kidinov kidinov linked an issue May 24, 2023 that may be closed by this pull request
@kidinov kidinov added this to the 13.8 milestone May 24, 2023
@kidinov kidinov requested a review from samiuelson May 24, 2023 10:38
@kidinov kidinov added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label May 24, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 24, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (4d9f86d) 43.82% compared to head (c89a172) 43.64%.

❗ Current head c89a172 differs from pull request most recent head e1b4ba4. Consider uploading reports for the commit e1b4ba4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #9098      +/-   ##
============================================
- Coverage     43.82%   43.64%   -0.18%     
+ Complexity     4154     4119      -35     
============================================
  Files           843      842       -1     
  Lines         44511    44190     -321     
  Branches       5827     5785      -42     
============================================
- Hits          19505    19285     -220     
+ Misses        23309    23216      -93     
+ Partials       1697     1689       -8     
Impacted Files Coverage Δ
.../com/woocommerce/android/extensions/ActivityExt.kt 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AnirudhBhat AnirudhBhat self-assigned this May 26, 2023
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat enabled auto-merge May 26, 2023 06:19
@AnirudhBhat AnirudhBhat merged commit 1cfe40c into trunk May 26, 2023
@AnirudhBhat AnirudhBhat deleted the 9089-scan-to-pay-increase-brightness-when-qr-is-visible branch May 26, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Scan To Pay] increase brightness when QR is visible

5 participants