Feature/9080 share store my store tab #9102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
JorgeMucientes
added
the
feature: store onboarding
Generated by 🚫 dangerJS |
JorgeMucientes
force-pushed
the
feature/9080-share-store-my-store-tab
branch
from
6aafebc to
665da4c
Compare
JorgeMucientes
force-pushed
the
feature/9080-share-store-my-store-tab
branch
from
665da4c to
a17bdd9
Compare
Collaborator
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
hafizrahman
reviewed
May 25, 2023
| PrivacyBannerFragmentDirections.actionGlobalPrivacyBannerFragment() | ||
| ) | ||
|
|
||
| is ShareStore -> ActivityUtils.shareStoreUrl(requireActivity(), event.storeUrl) |
Contributor
There was a problem hiding this comment.
Good find, interesting that it's been there for years without being used :)
hafizrahman
approved these changes
May 25, 2023
Contributor
hafizrahman
left a comment
hafizrahman
left a comment
There was a problem hiding this comment.
LGTM and works as expected.
Just want to mention that we've discussed internally that the checking will eventually be replaced by checking the privacy status of the site (public vs others) instead of checking for onboarding LAUNCH_YOUR_STORE status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #9080
Description
As part of improving the product sharing experience, we are adding a new CTA to share user's store URL from my store tab. This button will be visible only if the store is
public(has been launched).Testing instructions
🔵 Tracked dashboard_share_your_store_button_tapped.share.mp4