[FIX] ProductImagesFragment activity death

[kidinov]

Closes: #9100

Description

Sentry Issue: WOOCOMMERCE-ANDROID-6VF

To reproduce the crash:

• Open a product
• Click on the image
• Open image
• Enabled don't keep activities
• Return back to the app

The crash happens because two fragments use the same ViewModel while inside of the model, it expects specific sets of arguments passed from a Bundle

private val navArgs: ProductImagesFragmentArgs by savedState.navArgs()

In the older version of Hilt, for some unclear reason in this situation, it was a passing bundle from the first fragment in the back stack, which was ProductImagesFragment, and therefore crash didn't happen, although the state could be inconsistent already because state inside of the VM not recreated properly.

With the update hilt, it passes the latest bundle there; that's why it cannot recover required images

As a quick workaround, I just pass all the arguments from the first fragment to the second, but issues with the state still stay here because there is an inconsistency between the stored in the bundle state and the state that is kept inside the VM

Ideally, we should decouple two fragments and use 2 VMs and communicate.

Testing instructions

Images/gif

• Open a product
• Click on the image
• Open image
• Enabled don't keep activities
• Return back to the app
• Notice that it doesn't crash anymore

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[wpmobilebot]

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

[0nko]

LGTM 👍