[FIX] Order editing crash after activity death #9113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments activity recrection crash fix
Generated by 🚫 dangerJS |
Collaborator
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
Contributor
|
@kidinov 👋 I'm unable to reproduce this issue, could you please point me to what I'm doing wrong? Thu.May.25.14.16.53.CEST.2023.mp4 |
Contributor
Author
|
@wzieba, you should hide when you are on the note adding screen, enabled don't keep activity and then come back Or just hide and show it when don't keep activities option is active |
Contributor
|
I see 🤦 thanks, I was able to reproduce now 👍 |
wzieba
approved these changes
May 25, 2023
Contributor
wzieba
left a comment
wzieba
left a comment
There was a problem hiding this comment.
Thanks! The fix works well, the app is no longer crashing.
The workaround is not ideal - we may want to completely redesign the architecture of the taken approach
I agree - I think it's fairly easy, if someone doesn't know about this issue, to introduce a similar bug in the future.
Nevertheless, for the given circumstances, the proposed fix suites well 👍 
wzieba
deleted the
9112-runtimeexception-javalangreflectinvocationtargetexception-order-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9112
Description
Sentry Issue: WOOCOMMERCE-ANDROID-6PW
To reproduce:
don't keep activitiesThe crash happens because 3 fragments use the same ViewModel while inside of the model, it expects specific sets of arguments passed from a Bundle
In the older version of Hilt, for some unclear reason in this situation, it was a passing bundle from the first fragment in the back stack, which was
OrderDetailsFragment, and therefore crash didn't happenWith the update hilt, it passes the latest bundle there - that's why it cannot recover the required
orderIdThe PR passes
orderIdto the fragments so it will be in the Bundle. The workaround is not ideal - we may want to completely redesign the architecture of the taken approachTesting instructions
Images/gif
don't keep activitiesRELEASE-NOTES.txtif necessary.