-
Notifications
You must be signed in to change notification settings - Fork 136
Scanned and deliver final PR to turn off the feature flag #9125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| COMPOSITE_PRODUCTS_READ_ONLY_SUPPORT, | ||
| EU_SHIPPING_NOTIFICATION -> true | ||
| EU_SHIPPING_NOTIFICATION, | ||
| IPP_ADD_PRODUCT_VIA_BARCODE_SCANNER -> true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove the flag so it doesn't clutter the code base? If for some reason you'll need to disable it it will be matter of one commit revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
kidinov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But I would really remove the flag - we have 16 flags set to true, and some of them are a year old. I think this is an introduction a tech debt and increasing complexity when it;s not needed
Generated by 🚫 dangerJS |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #9125 +/- ##
============================================
+ Coverage 43.83% 43.86% +0.03%
+ Complexity 4154 4144 -10
============================================
Files 844 843 -1
Lines 44499 44305 -194
Branches 5825 5799 -26
============================================
- Hits 19505 19435 -70
+ Misses 23297 23176 -121
+ Partials 1697 1694 -3
☔ View full report in Codecov by Sentry. |
Description
This PR turns off the Scanned and Deliver feature flag and adds release notes.
Here are the list of PRs related to this feature
Testing instructions
All the above PRs are tested and reviewed. Just ensure the CI is happy.
RELEASE-NOTES.txtif necessary.