Skip to content

Conversation

@AnirudhBhat
Copy link
Contributor

Description

This PR turns off the Scanned and Deliver feature flag and adds release notes.

Here are the list of PRs related to this feature

  1. Add feature flag for "Scanned and Deliver" #8964
  2. Issue/8942 business logic google code scanner #8996
  3. Order creation - Integrate search product by SKU for barcode scanning #9053
  4. Code scanner UI in the order detail screen #9054
  5. Code scanner UI in the order listing screen #9069
  6. Barcode scanning - Handle failure case #9082
  7. Increment product quantity when the same product is scanned more than one time #9083
  8. Analytics for scanned and deliver #9110

Testing instructions

All the above PRs are tested and reviewed. Just ensure the CI is happy.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@AnirudhBhat AnirudhBhat requested a review from kidinov May 25, 2023 12:20
@AnirudhBhat AnirudhBhat added the feature: mobile payments Related to mobile payments / card present payments / Woo Payments. label May 25, 2023
@AnirudhBhat AnirudhBhat added this to the 13.8 milestone May 25, 2023
@AnirudhBhat AnirudhBhat marked this pull request as ready for review May 25, 2023 12:21
@kidinov kidinov self-assigned this May 25, 2023
COMPOSITE_PRODUCTS_READ_ONLY_SUPPORT,
EU_SHIPPING_NOTIFICATION -> true
EU_SHIPPING_NOTIFICATION,
IPP_ADD_PRODUCT_VIA_BARCODE_SCANNER -> true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the flag so it doesn't clutter the code base? If for some reason you'll need to disable it it will be matter of one commit revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidinov I've removed the usage of the Scanned and Deliver feature flag from our codebase. d2d4516

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 25, 2023

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@kidinov kidinov self-requested a review May 25, 2023 12:46
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I would really remove the flag - we have 16 flags set to true, and some of them are a year old. I think this is an introduction a tech debt and increasing complexity when it;s not needed

@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@AnirudhBhat AnirudhBhat enabled auto-merge May 25, 2023 13:12
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.03 🎉

Comparison is base (e9fb302) 43.83% compared to head (a4f150f) 43.86%.

❗ Current head a4f150f differs from pull request most recent head fbe18a2. Consider uploading reports for the commit fbe18a2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #9125      +/-   ##
============================================
+ Coverage     43.83%   43.86%   +0.03%     
+ Complexity     4154     4144      -10     
============================================
  Files           844      843       -1     
  Lines         44499    44305     -194     
  Branches       5825     5799      -26     
============================================
- Hits          19505    19435      -70     
+ Misses        23297    23176     -121     
+ Partials       1697     1694       -3     
Impacted Files Coverage Δ
...kotlin/com/woocommerce/android/util/FeatureFlag.kt 73.46% <33.33%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AnirudhBhat AnirudhBhat merged commit 9e2cd20 into trunk May 25, 2023
@AnirudhBhat AnirudhBhat deleted the feature/scanned-and-deliver branch May 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants