-
Notifications
You must be signed in to change notification settings - Fork 136
Track barcode format when the product search via SKU fails #9129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #9129 +/- ##
============================================
+ Coverage 43.81% 43.88% +0.06%
- Complexity 4154 4169 +15
============================================
Files 843 844 +1
Lines 44514 44576 +62
Branches 5827 5827
============================================
+ Hits 19505 19563 +58
- Misses 23312 23314 +2
- Partials 1697 1699 +2
☔ View full report in Codecov by Sentry. |
| @Parcelize | ||
| object FormatCodaBar : BarcodeFormat("codabar") | ||
| @Parcelize | ||
| object FormatCode128 : BarcodeFormat("code 128") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: maybe to use code_128 etc as this is for tracking and we usually use this notation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here: 0429ad9
| android:name="sku" | ||
| app:argType="string" | ||
| app:nullable="true"/> | ||
| <argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: you can consider putting Sku and BarcodeFormat in one structure, so there will be a compile time check that it should be either both SKU and BarcodeFormat or none of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I'll take this in a separate PR just so that we can merge and get the feature out to merchants.
kidinov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tracked: product_search_via_sku_failure, Properties: {"source":"order_list","barcode_format":"qr code","reason":"Empty data response (no product found for the SKU)","blog_id":192152755,"is_wpcom_store":true,"is_debug":true}
Closes: #9126
Description
This PR tracks the barcode format when the product search via SKU fails. This information gives us which barcode format is failing the most. Do we need to handle the checksum for that format ...etc
More context: p1685078975281749-slack-C025A8VV728
Testing instructions
barcode_formatproperty is proper.RELEASE-NOTES.txtif necessary.