Skip to content

Autoloader: Renaming the main extension files #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: try/add-basic-classmap-autoloader
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented May 28, 2025

Fixes STRIPE-506
Base PR #4260

Changes proposed in this Pull Request:

As part of the autoloader implementation, this PR renames all the main extension files to follow the PSR-4 autoloading standard. The goal of this change is to implement the default composer autoloader in a following PR.

Testing instructions

Code review. Check if the tests are still passing.

Perform some smoking testing to make sure no regression was introduced:

  • Connect a Stripe account
  • Toggle some payment methods
  • Toggle legacy checkout
  • Perform some purchases in both shortcode and block checkout
  • Try simple products, subscriptions, and pre-orders

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this May 28, 2025
@wjrosa wjrosa force-pushed the dev/renaming-the-main-extension-files branch from ed6ec32 to b9c68fd Compare May 29, 2025 12:51
@wjrosa wjrosa marked this pull request as ready for review May 29, 2025 13:06
@wjrosa wjrosa requested review from a team and malithsen and removed request for a team May 29, 2025 13:40
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! Smoke tests were successful!

Given the scope of these file renames, I’m wondering if we should hold these off from the next release. Large-scale renames can sometimes surface subtle, hard-to-debug issues. We should probably discuss this with the team :)

@wjrosa
Copy link
Contributor Author

wjrosa commented May 30, 2025

Thank you for your review, Malith!

Given the scope of these file renames, I’m wondering if we should hold these off from the next release. Large-scale renames can sometimes surface subtle, hard-to-debug issues. We should probably discuss this with the team :)

Absolutely, that was the plan. This will be merged only after Dale's PR lands. And I will outline the whole rollout plan on a P2 soon

@wjrosa wjrosa added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jun 2, 2025
@wjrosa wjrosa changed the title Renaming the main extension files Autoloader: Renaming the main extension files Jun 3, 2025
Copy link

github-actions bot commented Jun 5, 2025

📈 PHP Unit Code Coverage Report

Package Line Rate Health
includes/WC_Stripe_Customer.php 40%
Summary 44% (7261 / 16496)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants