-
Notifications
You must be signed in to change notification settings - Fork 211
Autoloader: Renaming the main extension files #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: try/add-basic-classmap-autoloader
Are you sure you want to change the base?
Autoloader: Renaming the main extension files #4373
Conversation
ed6ec32
to
b9c68fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! Smoke tests were successful!
Given the scope of these file renames, I’m wondering if we should hold these off from the next release. Large-scale renames can sometimes surface subtle, hard-to-debug issues. We should probably discuss this with the team :)
Thank you for your review, Malith!
Absolutely, that was the plan. This will be merged only after Dale's PR lands. And I will outline the whole rollout plan on a P2 soon |
…e-main-extension-files
📈 PHP Unit Code Coverage Report
|
Fixes STRIPE-506
Base PR #4260
Changes proposed in this Pull Request:
As part of the autoloader implementation, this PR renames all the main extension files to follow the PSR-4 autoloading standard. The goal of this change is to implement the default composer autoloader in a following PR.
Testing instructions
Code review. Check if the tests are still passing.
Perform some smoking testing to make sure no regression was introduced:
Changelog entry
Changelog Entry Comment
Comment
Post merge