Subscription detached notice when viewing subscription #4393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayisha
reviewed
Jun 5, 2025
| * @return bool | ||
| */ | ||
| public static function is_subscription_edit_page() { | ||
| if ( apply_filters( 'wc_stripe_is_subscription_edit_page', false ) ) { |
There was a problem hiding this comment.
Curious about why we are using this wc_stripe_is_subscription_edit_page filter in 3 places and what is the thought behind introducing this filter.
There was a problem hiding this comment.
It is basically used for unit tests. For some reason, I could not overwrite the check for the page using the query params. I tried multiple ways, but none worked. So I decided to use this filter instead.
I have improved the code in e4e48e1
…iption-detached-notice
📈 PHP Unit Code Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes STRIPE-500
Changes proposed in this Pull Request:
As part of STRIPE-483, this PR adds a new notice to the subscription edit page in wp-admin when the subscription payment method is detached. It also includes information about the new tool introduced in #4391
Notice preview:
I am also taking the opportunity to introduce the new page helper class I created a POC for here.
Testing instructions
add/single-subscription-detached-notice)includes/compat/class-wc-stripe-subscriptions-helper.php:53andincludes/compat/class-wc-stripe-subscriptions-helper.php:88)includes/compat/class-wc-stripe-subscriptions-helper.php:74andincludes/compat/class-wc-stripe-subscriptions-helper.php:77, also comment out the closing brackets to avoid breaking the block) ** You can also purchase subscriptions as a shopper and detach their payment method using the Stripe dashboard instead.
Changelog entry
Changelog Entry Comment
Comment
Post merge