Unit tests for the banners refactoring #4397
Open
+400
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mayisha <[email protected]>
Base automatically changed from
add/new-banners-for-bnpl-upon-legacy-checkout-deprecation
to
develop
June 5, 2025 16:36
daledupreez
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Things are looking good enough to me, with the exception of using the test IDs.
That said, might it be worth aiming for more integration-y tests that validate we see the expected banners in the main UI, and not just rely on lower-level unit tests? (That work could be tackled in a follow-up PR.)
| value: { assign }, | ||
| } ); | ||
| } ); | ||
| it( 'should create error notice when oauth URLs are invalid', () => { |
There was a problem hiding this comment.
Can we test that we throw an error when the expected live and test URLs are null separately?
There was a problem hiding this comment.
I'm sorry, but I'm not sure if I understand. Do you mean move it to a separate describe clause?
client/settings/payment-settings/promotional-banner/new-checkout-experience-apms-banner.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base PR #4328
Changes proposed in this Pull Request:
On the base PR I did a considerable refactoring of the promotional banners. I am adding unit tests for all the new JS files here to make the code more reliable.
Testing instructions
Code review. Check if the tests make sense and are still passing.
Changelog entry
Changelog Entry Comment
Comment
Post merge