Update PMC cache keys, and remove fallback cache #4398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR removes the cache key prefix from the Payment_Method_Configurations class; it's no longer needed. #4370 included that logic into the Database Cache.
It also removes the fallback cache; the new database cache uses the same
options
table to store data, making it redundant.Testing instructions
Code review.
Follow the original implementation testing instructions: #4331
Also, this Dev Tools plugin PR adds a way to see (and delete) the new database cache entries (with TTL and expiration), which makes things easier to test without manually checking the database with wp-cli:
Changelog entry
Changelog Entry Comment
Comment
Post merge