Fix PHPStan handling of plugin constants defined via function calls #4891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR works around a bug or limitation in PHPStan where it does not recognise constants defined using the return value from a function. The issue was resulting in the
WC_STRIPE_PLUGIN_URLandWC_STRIPE_PLUGIN_PATHconstants not being found/seen by PHPStan. To work around the issue, I've added conditional definitions for those two constants inphpstan-stubs/wc_stripe_constants.phpso they get picked up during PHPStan analysis runs. Note that the values are not correct, as we need to use constant values for both.I have also updated the PHPStan baseline to remove the previously tracked errors stemming from the "missing" constants.
Testing instructions
Code review should be good enough on this one, and the PHPStan analysis should be clean.
Changelog entry
Changelog Entry Comment
Comment
Post merge