Skip to content

Conversation

@daledupreez
Copy link
Contributor

Changes proposed in this Pull Request:

This PR adds missingType.iterableValue errors to the list of errors that we want PHPStan to ignore completely. Loosely typed arrays are _everywhere_in WordPress and WooCommerce, so it feels like requiring typed arrays is overkill (at least for now). The PR also updates our PHPStan baseline file with the new configuration.

Testing instructions

Code review. Confirm that PHPStan analysis passes.


  • [N/A] Covered with tests (or have a good reason not to test in description ☝️)
  • [N/A] Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

This is a pretty limited change to our PHPStan configuration, which is not really relevant to anyone outside the development team.

Post merge

@daledupreez daledupreez requested review from a team, Mayisha and malithsen and removed request for a team December 24, 2025 15:58
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants