Ignore missingType.iterableValue errors from PHPStan #4892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adds
missingType.iterableValueerrors to the list of errors that we want PHPStan to ignore completely. Loosely typed arrays are _everywhere_in WordPress and WooCommerce, so it feels like requiring typed arrays is overkill (at least for now). The PR also updates our PHPStan baseline file with the new configuration.Testing instructions
Code review. Confirm that PHPStan analysis passes.
Changelog entry
Changelog Entry Comment
Comment
This is a pretty limited change to our PHPStan configuration, which is not really relevant to anyone outside the development team.
Post merge