Skip to content

Comments

Fix PHPDoc issues reported by PHPStan#4955

Draft
daledupreez wants to merge 9 commits intodevelopfrom
try/fix-phstan-issues-with-agent
Draft

Fix PHPDoc issues reported by PHPStan#4955
daledupreez wants to merge 9 commits intodevelopfrom
try/fix-phstan-issues-with-agent

Conversation

@daledupreez
Copy link
Contributor

Fixes STRIPE-<linear_issue_id>
Fixes #<github_issue_id>

Changes proposed in this Pull Request:

This PR updates the PHPDoc for large sections of our codebase to address issues reported by PHPStan, both to make it clearer what the expected behaviour is, and to make it easier to flag incorrect usage in the plugin.

Warning

I used multiple agents to iteratively get to this point, so I still need to review the full set of changes myself. We may need to split this PR into multiple smaller PRs so we can continue to make progress.

Testing instructions


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant