Fix more Periphery warnings. To test: POS search history, shadow.

Author: jaclync

Modules/Sources/Yosemite/PointOfSale/POSSearchHistoryService.swift

@@ -4,8 +4,6 @@ import Storage
 public protocol POSSearchHistoryProviding {
     func saveSuccessfulSearch(term: String, for itemType: POSItemType)
     func searchHistory(for itemType: POSItemType) -> [String]
-    func clearSearchHistory(for itemType: POSItemType)
-    func clearAllSearchHistory()
 }
 
 /// Service for managing search history in the Point of Sale
@@ -60,18 +58,4 @@ public final class POSSearchHistoryService: POSSearchHistoryProviding {
     public func searchHistory(for itemType: POSItemType) -> [String] {
         return siteSpecificAppSettingsStoreMethods.getSearchTerms(for: itemType, siteID: siteID)
     }
-
-    /// Clears the search history for a specific item type
-    /// - Parameter itemType: The type of item to clear search history for
-    public func clearSearchHistory(for itemType: POSItemType) {
-        siteSpecificAppSettingsStoreMethods.setSearchTerms([], for: itemType, siteID: siteID)
-    }
-
-    /// Clears all search history
-    public func clearAllSearchHistory() {
-        // Clear search history for all item types
-        POSItemType.allCases.forEach { itemType in
-            clearSearchHistory(for: itemType)
-        }
-    }
 }

Modules/Tests/YosemiteTests/PointOfSale/POSSearchHistoryServiceTests.swift

@@ -89,38 +89,6 @@ struct POSSearchHistoryServiceTests {
         #expect(history.isEmpty)
     }
 
-    @Test func clearSearchHistory_clears_history_for_specific_item_type() throws {
-        // Given
-        sut.saveSuccessfulSearch(term: "product", for: .product)
-        sut.saveSuccessfulSearch(term: "coupon", for: .coupon)
-
-        // When
-        sut.clearSearchHistory(for: .product)
-
-        // Then
-        let productsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.product])
-        let couponsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.coupon])
-        #expect(productsSearchHistory.isEmpty)
-        #expect(couponsSearchHistory.count == 1)
-        #expect(couponsSearchHistory.first == "coupon")
-    }
-
-    @Test func clearAllSearchHistory_clears_all_history() throws {
-        // Given
-        mockStoreMethods.mockSearchTerms[.product] = ["product"]
-        mockStoreMethods.mockSearchTerms[.coupon] = ["coupon"]
-
-        // When
-        sut.clearAllSearchHistory()
-
-        // Then
-        #expect(mockStoreMethods.setSearchTermsCalled)
-        let productsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.product])
-        let couponsSearchHistory = try #require(mockStoreMethods.mockSearchTerms[.coupon])
-        #expect(productsSearchHistory.isEmpty)
-        #expect(couponsSearchHistory.isEmpty)
-    }
-
     @Test func search_history_is_separate_for_different_item_types() {
         // Given
         mockStoreMethods.mockSearchTerms[.product] = ["product"]

WooCommerce/Classes/POS/Utils/POSShadowStyle.swift

@@ -108,7 +108,6 @@ extension View {
 private class MultiShadowView: UIView {
     var cornerRadius: CGFloat = 0
     var shadowLayers: [POSShadowLayer] = []
-    var fillColor: UIColor = .clear
 
     override func layoutSubviews() {
         super.layoutSubviews()
@@ -141,14 +140,12 @@ private struct RasterizedShadowBackground: UIViewRepresentable {
         let view = MultiShadowView()
         view.cornerRadius = cornerRadius
         view.shadowLayers = shadowLayers
-        view.fillColor = backgroundColor
         return view
     }
 
     func updateUIView(_ uiView: MultiShadowView, context: Context) {
         uiView.cornerRadius = cornerRadius
         uiView.shadowLayers = shadowLayers
-        uiView.fillColor = backgroundColor
         uiView.setNeedsLayout()
     }
 }

WooCommerce/Classes/POS/Utils/PreviewHelpers.swift

@@ -150,10 +150,6 @@ final class PointOfSalePreviewHistoryService: POSSearchHistoryProviding {
     func searchHistory(for itemType: POSItemType) -> [String] {
         return []
     }
-
-    func clearSearchHistory(for itemType: POSItemType) {}
-
-    func clearAllSearchHistory() {}
 }
 
 private var mockItems: [POSItem] {

WooCommerce/WooCommerceTests/POS/Mocks/MockPOSSearchHistoryService.swift

@@ -7,8 +7,4 @@ struct MockPOSSearchHistoryService: POSSearchHistoryProviding {
     func searchHistory(for itemType: POSItemType) -> [String] {
         return []
     }
-
-    func clearSearchHistory(for itemType: POSItemType) {}
-
-    func clearAllSearchHistory() {}
 }