Merge pull request #8525 from woocommerce/feat/8453-woo-check

REST API: Check for Woo after authentication

Author: itsmeichigo

Networking/Networking/Model/WordPressSite.swift

@@ -24,12 +24,23 @@ public struct WordPressSite: Decodable, Equatable {
     ///
     public let gmtOffset: String
 
-    public init(name: String, description: String, url: String, timezone: String, gmtOffset: String) {
+    /// Namespaces supported by the site.
+    ///
+    public let namespaces: [String]
+
+    /// Whether WooCommerce is one of the active plugins in the site.
+    ///
+    public var isWooCommerceActive: Bool {
+        namespaces.contains { $0.hasPrefix(Constants.wooNameSpace) }
+    }
+
+    public init(name: String, description: String, url: String, timezone: String, gmtOffset: String, namespaces: [String]) {
         self.name = name
         self.description = description
         self.url = url
         self.timezone = timezone
         self.gmtOffset = gmtOffset
+        self.namespaces = namespaces
     }
 }
 
@@ -47,7 +58,7 @@ public extension WordPressSite {
               plan: "",
               isJetpackThePluginInstalled: false,
               isJetpackConnected: false,
-              isWooCommerceActive: true, // we expect to only call this after checking Woo is active
+              isWooCommerceActive: isWooCommerceActive,
               isWordPressComStore: false,
               jetpackConnectionActivePlugins: [],
               timezone: timezone,
@@ -64,10 +75,12 @@ private extension WordPressSite {
         case url
         case timezone = "timezone_string"
         case gmtOffset = "gmt_offset"
+        case namespaces
     }
 
     enum Constants {
         static let adminPath = "/wp-admin"
         static let loginPath = "/wp-login.php"
+        static let wooNameSpace = "wc/"
     }
 }

Networking/NetworkingTests/Mapper/WordPressSiteMapperTests.swift

@@ -13,6 +13,8 @@ final class WordPressSiteMapperTests: XCTestCase {
         XCTAssertEqual(site.url, "https://test.com")
         XCTAssertEqual(site.gmtOffset, "0")
         XCTAssertEqual(site.timezone, "")
+        XCTAssertFalse(site.namespaces.isEmpty)
+        XCTAssertFalse(site.isWooCommerceActive)
     }
 }
 

Networking/NetworkingTests/Responses/wordpress-site-info.json

@@ -6,4 +6,10 @@
     "gmt_offset": "0",
     "timezone_string": "",
     "authentication": [],
+    "namespaces": [
+        "oembed/1.0",
+        "wp/v2",
+        "wp-site-health/v1",
+        "wp-block-editor/v1"
+      ]
 }

WooCommerce/Classes/Authentication/AuthenticationManager.swift

@@ -3,15 +3,12 @@ import KeychainAccess
 import WordPressAuthenticator
 import WordPressKit
 import Yosemite
-import WordPressUI
 import class Networking.UserAgent
 import enum Experiments.ABTest
 import struct Networking.Settings
 import protocol Experiments.FeatureFlagService
 import protocol Storage.StorageManagerType
-import protocol Networking.ApplicationPasswordUseCase
 import class Networking.DefaultApplicationPasswordUseCase
-import enum Networking.ApplicationPasswordUseCaseError
 
 /// Encapsulates all of the interactions with the WordPress Authenticator
 ///
@@ -48,13 +45,8 @@ class AuthenticationManager: Authentication {
 
     private let analytics: Analytics
 
-    /// Keep strong reference of the use case to check for application password availability if necessary.
-    private var applicationPasswordUseCase: ApplicationPasswordUseCase?
-
-    /// Keep strong reference of the use case to check for role eligibility if necessary.
-    private lazy var roleEligibilityUseCase: RoleEligibilityUseCase = {
-        .init(stores: ServiceLocator.stores)
-    }()
+    /// Keeps a reference to the checker
+    private var postSiteCredentialLoginChecker: PostSiteCredentialLoginChecker?
 
     init(storageManager: StorageManagerType = ServiceLocator.storageManager,
          featureFlagService: FeatureFlagService = ServiceLocator.featureFlagService,
@@ -391,8 +383,7 @@ extension AuthenticationManager: WordPressAuthenticatorDelegate {
            featureFlagService.isFeatureFlagEnabled(.applicationPasswordAuthenticationForSiteCredentialLogin) {
             return didAuthenticateUser(to: siteURL,
                                        with: siteCredentials,
-                                       in: navigationController,
-                                       source: source)
+                                       in: navigationController)
         }
 
         /// Jetpack is required. Present an error if we don't detect a valid installation for a self-hosted site.
@@ -736,7 +727,7 @@ private extension AuthenticationManager {
     /// The error screen to be displayed when the user tries to enter a site without WooCommerce.
     ///
     func noWooUI(for site: Site,
-                 with matcher: ULAccountMatcher,
+                 with matcher: ULAccountMatcher = .init(),
                  navigationController: UINavigationController,
                  onStorePickerDismiss: @escaping () -> Void) -> UIViewController {
         let viewModel = NoWooErrorViewModel(
@@ -800,139 +791,24 @@ private extension AuthenticationManager {
         return accountMismatchUI(for: site.url, siteCredentials: nil, with: matcher, in: navigationController)
     }
 
-    /// The error screen to be displayed when the user tries to log in with site credentials
-    /// with application password disabled.
-    ///
-    func applicationPasswordDisabledUI(for siteURL: String) -> UIViewController {
-        let viewModel = ApplicationPasswordDisabledViewModel(siteURL: siteURL)
-        return ULErrorViewController(viewModel: viewModel)
-    }
-
     /// Checks if the authenticated user is eligible to use the app and navigates to the home screen.
     ///
     func didAuthenticateUser(to siteURL: String,
                              with siteCredentials: WordPressOrgCredentials,
-                             in navigationController: UINavigationController,
-                             source: SignInSource?) {
-        // check if application password is enabled
-        guard let applicationPasswordUseCase = try? DefaultApplicationPasswordUseCase(
+                             in navigationController: UINavigationController) {
+        guard let useCase = try? DefaultApplicationPasswordUseCase(
             username: siteCredentials.username,
             password: siteCredentials.password,
             siteAddress: siteCredentials.siteURL
         ) else {
             return assertionFailure("⛔️ Error creating application password use case")
         }
-        self.applicationPasswordUseCase = applicationPasswordUseCase
-        checkApplicationPassword(for: siteURL,
-                                 with: applicationPasswordUseCase,
-                                 in: navigationController) { [weak self] in
-            guard let self else { return }
-            self.checkRoleEligibility(in: navigationController) { [weak self] in
-                guard let self else { return }
-                // TODO: check for Woo
-                // navigates to home screen immediately with a placeholder store ID
-                self.startStorePicker(with: WooConstants.placeholderStoreID, in: navigationController)
-            }
+        let checker = PostSiteCredentialLoginChecker(applicationPasswordUseCase: useCase)
+        checker.checkEligibility(for: siteURL, from: navigationController) { [weak self] in
+            // navigates to home screen immediately with a placeholder store ID
+            self?.startStorePicker(with: WooConstants.placeholderStoreID, in: navigationController)
         }
-    }
-
-    func checkApplicationPassword(for siteURL: String,
-                                  with useCase: ApplicationPasswordUseCase,
-                                  in navigationController: UINavigationController, onSuccess: @escaping () -> Void) {
-        Task {
-            do {
-                let _ = try await useCase.generateNewPassword()
-                await MainActor.run {
-                    onSuccess()
-                }
-            } catch ApplicationPasswordUseCaseError.applicationPasswordsDisabled {
-                // show application password disabled error
-                await MainActor.run {
-                    let errorUI = applicationPasswordDisabledUI(for: siteURL)
-                    navigationController.show(errorUI, sender: nil)
-                }
-            } catch {
-                // show generic error
-                await MainActor.run {
-                    DDLogError("⛔️ Error generating application password: \(error)")
-                    let alert = FancyAlertViewController.makeSiteCredentialLoginAlert(
-                        message: Localization.applicationPasswordError,
-                        retryAction: { [weak self] in
-                            self?.checkApplicationPassword(for: siteURL, with: useCase, in: navigationController, onSuccess: onSuccess)
-                        },
-                        restartLoginAction: {
-                            ServiceLocator.stores.deauthenticate()
-                            navigationController.popToRootViewController(animated: true)
-                        }
-                    )
-                    navigationController.present(alert, animated: true)
-                }
-            }
-        }
-    }
-
-    /// Checks role eligibility for the logged in user with the site address saved in the credentials.
-    /// Placeholder store ID is used because we are checking for users logging in with site credentials.
-    ///
-    func checkRoleEligibility(in navigationController: UINavigationController, onSuccess: @escaping () -> Void) {
-        roleEligibilityUseCase.checkEligibility(for: WooConstants.placeholderStoreID) { [weak self] result in
-            guard let self else { return }
-            switch result {
-            case .success:
-                onSuccess()
-            case .failure(let error):
-                if case let RoleEligibilityError.insufficientRole(errorInfo) = error {
-                    self.showRoleErrorScreen(for: WooConstants.placeholderStoreID,
-                                             errorInfo: errorInfo,
-                                             in: navigationController,
-                                             onSuccess: onSuccess)
-                } else {
-                    // show generic error
-                    DDLogError("⛔️ Error checking role eligibility: \(error)")
-                    let alert = FancyAlertViewController.makeSiteCredentialLoginAlert(
-                        message: Localization.roleEligibilityCheckError,
-                        retryAction: { [weak self] in
-                            self?.checkRoleEligibility(in: navigationController, onSuccess: onSuccess)
-                        },
-                        restartLoginAction: {
-                            ServiceLocator.stores.deauthenticate()
-                            navigationController.popToRootViewController(animated: true)
-                        }
-                    )
-                    navigationController.present(alert, animated: true)
-                }
-            }
-        }
-    }
-
-    /// Shows a Role Error page using the provided error information.
-    ///
-    func showRoleErrorScreen(for siteID: Int64,
-                             errorInfo: StorageEligibilityErrorInfo,
-                             in navigationController: UINavigationController,
-                             onSuccess: @escaping () -> Void) {
-        let errorViewModel = RoleErrorViewModel(siteID: siteID, title: errorInfo.name, subtitle: errorInfo.humanizedRoles, useCase: self.roleEligibilityUseCase)
-        let errorViewController = RoleErrorViewController(viewModel: errorViewModel)
-
-        errorViewModel.onSuccess = onSuccess
-        errorViewModel.onDeauthenticationRequest = {
-            ServiceLocator.stores.deauthenticate()
-            navigationController.popToRootViewController(animated: true)
-        }
-        navigationController.show(errorViewController, sender: self)
-    }
-}
-
-private extension AuthenticationManager {
-    enum Localization {
-        static let applicationPasswordError = NSLocalizedString(
-            "Error fetching application password for your site.",
-            comment: "Error message displayed when application password cannot be fetched after authentication."
-        )
-        static let roleEligibilityCheckError = NSLocalizedString(
-            "Error fetching user information.",
-            comment: "Error message displayed when user information cannot be fetched after authentication."
-        )
+        self.postSiteCredentialLoginChecker = checker
     }
 }