Simplify predicate logic

Author: itsmeichigo

WooCommerce/Classes/Bookings/BookingFilters/SyncableListSelectorViewModel.swift

@@ -84,17 +84,11 @@ final class SyncableListSelectorViewModel<Syncable: ListSyncable>: ObservableObj
         currentSearchKeyword = query
 
         // Update the predicate to filter by search results if needed
-        if query.isEmpty {
-            // Reset to base predicate when search is cleared
-            resultsController.predicate = syncable.createPredicate()
-        } else if let searchPredicate = syncable.createSearchPredicate(keyword: query) {
-            // Combine base predicate with search predicate
-            let basePredicate = syncable.createPredicate()
-            resultsController.predicate = NSCompoundPredicate(andPredicateWithSubpredicates: [basePredicate, searchPredicate])
-        } else {
-            // Keep base predicate if search predicate is not available
-            resultsController.predicate = syncable.createPredicate()
+        var predicates = [syncable.createPredicate()]
+        if !query.isEmpty, let searchPredicate = syncable.createSearchPredicate(keyword: query) {
+            predicates.append(searchPredicate)
         }
+        resultsController.predicate = NSCompoundPredicate(andPredicateWithSubpredicates: predicates)
 
         paginationTracker.syncFirstPage()
     }