Skip to content

Conversation

@bozidarsevo
Copy link
Contributor

@bozidarsevo bozidarsevo commented Nov 11, 2024

Description

  • Minor adaptations for the WooShippingPackagesRepository to prepare for connecting the backend response data.
  • Move saving template backend request to repository

Testing information

  1. Install and set up the Woo Shipping extension on your store.
  2. Build and run the app with the revampedShippingLabelCreation feature flag enabled.
  3. Create an order with the processing status and at least one physical product.
  4. In the order details, select "Create Shipping Label."
  5. Tap "Select a Package" button
  6. Input values for custom package
  7. Toggle switch to save template
  8. Save package as template
  9. Check on web that the new template with data you added is saved

Screenshots

Simulator Screen Recording - iPhone 16 Pro - 2024-11-21 at 12 28 26


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@bozidarsevo bozidarsevo added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Nov 11, 2024
@bozidarsevo bozidarsevo added this to the 21.2 milestone Nov 11, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 11, 2024

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 11, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14380-8d02b2c
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit8d02b2c
App Center BuildWooCommerce - Prototype Builds #11747
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@bozidarsevo bozidarsevo modified the milestones: 21.2, 21.3 Nov 15, 2024
@bozidarsevo bozidarsevo marked this pull request as ready for review November 25, 2024 11:30
@bozidarsevo bozidarsevo changed the title [WiP] Update package actions and repository Update package actions and repository Nov 25, 2024
@bozidarsevo bozidarsevo merged commit a57e2db into trunk Nov 25, 2024
16 checks passed
@bozidarsevo bozidarsevo deleted the issue/13553-package-actions-update branch November 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants