-
Notifications
You must be signed in to change notification settings - Fork 121
Shipping Labels: Add new screen to select category for HAZMAT #15368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
|
selanthiraiyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. 🚀
Closes: #15314
Also closes #15243
Description
This PR adds a new screen for selecting categories for HAZMAT. A few notes:
searchablehas some problems with the layout and text color (as reported in Blaze: Location search bar doesn't show placeholder initially #15243). I found that this was caused by our workaround of applying appearances to all the search bar in the app. This is not a good solution for the customization, and the search bars look better without it so I removed the legacy code. Please let me know if you think this should be reverted.Steps to reproduce
Testing information
Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the new screen matches the design. The search bar looks good on all screens.
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: