[Shipping Labels] Split shipment navigation #15369

selanthiraiyan · 2025-03-14T15:48:04Z

Description

Adds the split shipment row to the create label view and opens a WIP detail screen upon tapping the "Split Shipments" button.

Changes

New view for split shipments row.
View model to hold logic related to split shipments.
Detail view for split shipment.
Show split shipments row in create label view.

Steps to reproduce

Log in to a test store with Woo Shipping set up.
Open a completed order with at least one physical product.
Select "Create shipping label"
You should see the "Split Shipments" row.
Tapping the "Split Shipments" button should open a detail view. This screen is WIP.

Testing information

Validated that new split shipments row and detail screens are displayed.

Screenshots

Light	Dark

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

coderabbitai · 2025-03-14T15:48:11Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

wpmobilebot · 2025-03-14T16:05:37Z

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr15369-da2e8b2
	Version	21.9
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	`da2e8b2`
	App Center Build	WooCommerce - Prototype Builds #13323

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

itsmeichigo

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the navigation works as described. I left some non-blocking nits and questions but please feel free to add any changes in subsequent PRs.

itsmeichigo · 2025-03-17T03:33:52Z

...Create Shipping Labels/WooShipping Split Shipments/WooShippingSplitShipmentsDetailView.swift

+        NavigationView {
+            ScrollView {
+                VStack(alignment: .leading, spacing: Layout.contentPadding) {
+                    AdaptiveStack {


Nit: we should set the horizontal alignment to .leading to make the view look neater when big font sizes are set:

Thank you! Done in 304725a

itsmeichigo · 2025-03-17T03:34:30Z

...ipping Create Shipping Labels/WooShipping Split Shipments/WooShippingSplitShipmentsRow.swift

+            .buttonStyle(TextButtonStyle())
+        }
+        .padding(.vertical, Layout.verticalPadding)
+        .sheet(isPresented: $isShowingDetailView) {


Nit: sheet should be replaced with fullScreenCover to better match the design.

TIL about fullScreenCover. Thanks! Done in da2e8b2

itsmeichigo · 2025-03-17T03:36:49Z

...ls/Shipping Labels/WooShipping Create Shipping Labels/WooShippingCreateLabelsViewModel.swift

+    @MainActor
+    func loadShipmentsInfo() async {
+        splitShipmentsViewModel = WooShippingSplitShipmentsViewModel(siteID: order.siteID,
+                                                                     orderID: order.orderID,
+                                                                     stores: stores)
+    }


Is this also WIP? Should we disable splitting if an order has only one item?

Good point. Yes, this is WIP.

We need to load the shipment info from the remote and show this "Split shipments" view. I will update this after adding endpoint support in #15370.

selanthiraiyan · 2025-03-17T05:50:33Z

Thanks for the review and suggestions, Huong! 🙇

selanthiraiyan added 4 commits March 14, 2025 21:09

View for split shipment row.

8e844a7

View model for split shipments.

84b406f

Detail view for split shipments.

59885bf

Show shipments row in create labels view.

8ddb741

selanthiraiyan added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Mar 14, 2025

selanthiraiyan added this to the 22.0 milestone Mar 14, 2025

selanthiraiyan requested a review from itsmeichigo March 14, 2025 15:54

selanthiraiyan marked this pull request as ready for review March 14, 2025 15:54

Merge branch 'trunk' into task/15304-split-shipment-navigation

afd5a2d

itsmeichigo self-assigned this Mar 17, 2025

itsmeichigo approved these changes Mar 17, 2025

View reviewed changes

selanthiraiyan added 2 commits March 17, 2025 11:16

Update alignment.

304725a

Cover full screen to match design.

da2e8b2

selanthiraiyan enabled auto-merge March 17, 2025 05:50

selanthiraiyan merged commit 9947930 into trunk Mar 17, 2025
13 checks passed

selanthiraiyan deleted the task/15304-split-shipment-navigation branch March 17, 2025 06:08

[Shipping Labels] Split shipment navigation #15369

[Shipping Labels] Split shipment navigation #15369

Uh oh!

Conversation

selanthiraiyan commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to reproduce

Testing information

Screenshots

Reviewer (or Author, in the case of optional code reviews):

Uh oh!

coderabbitai bot commented Mar 14, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

wpmobilebot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsmeichigo left a comment

Choose a reason for hiding this comment

Uh oh!

itsmeichigo Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

selanthiraiyan Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

itsmeichigo Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

selanthiraiyan Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

itsmeichigo Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

selanthiraiyan Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

selanthiraiyan commented Mar 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

selanthiraiyan commented Mar 14, 2025 •

edited

Loading

wpmobilebot commented Mar 14, 2025 •

edited

Loading