Rename BuiltInReader / LocalMobileReader references to TapToPay #15380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staskus
added
type: task
Generated by 🚫 Danger |
staskus
added
the
category: tracks
4 tasks
|
|
staskus
force-pushed
the
task/consistent-tap-to-pay-naming
branch
from
a1abb8c to
9fd3115
Compare
staskus
requested review from
jaclync,
joshheald and
iamgabrielma
and removed request for
jaclync,
joshheald and
iamgabrielma
joshheald
approved these changes
Mar 27, 2025
Comment on lines
49
to
51
| CardReader(serial: "APPLE-BUILT-IN-SIMULATOR-1", | ||
| vendorIdentifier: "SIMULATOR", | ||
| name: "Simulated Apple Built In Reader", |
There was a problem hiding this comment.
Not a big deal, but maybe worth updating these strings too?
There was a problem hiding this comment.
Yes, these ones can be updated 👍
| @@ -1257,7 +1257,7 @@ extension WooAnalyticsEvent { | |||
|
|
|||
| enum CardReaderType: String { | |||
| case external | |||
| case builtIn = "built_in" | |||
| case tapToPay = "built_in" | |||
There was a problem hiding this comment.
I'm guessing this is deliberately left, to keep the analytics comparable over time?
There was a problem hiding this comment.
Yes. I kept all the analytics strings deliberately unchanged.
Comment on lines
+362
to
+368
| case cardReaderSelectTypeTapToPayTapped = "card_present_select_reader_type_built_in_tapped" | ||
| case cardReaderSelectTypeBluetoothTapped = "card_present_select_reader_type_bluetooth_tapped" | ||
| case cardReaderDiscoveryFailed = "card_reader_discovery_failed" | ||
| case cardReaderConnectionFailed = "card_reader_connection_failed" | ||
| case cardReaderConnectionSuccess = "card_reader_connection_success" | ||
| case cardReaderDisconnectTapped = "card_reader_disconnect_tapped" | ||
| case manageCardReadersBuiltInReaderAutoDisconnect = "manage_card_readers_automatic_disconnect_built_in_reader" | ||
| case manageCardReadersTapToPayReaderAutoDisconnect = "manage_card_readers_automatic_disconnect_built_in_reader" |
There was a problem hiding this comment.
I'm guessing these strings are deliberately left, to keep the analytics comparable over time?
There was a problem hiding this comment.
Yes. I kept all the analytics strings deliberately unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Stripe Terminal SDK update 4.2.0
Assigning everyone for a review for awareness. One is enough.
Description
A recent StripeSDK update renamed all the appleBuiltIn / localMobile references to TapToPay to match the branding.
I think it makes sense to do the same for Woo iOS codebase. It also helps with consistency, since we have all three used throughout the codebase: builtIn, local, tapToPay.
I didn't rename events to keep the analytics data consistent.
Steps to reproduce
Testing information
Tested on iPhone 14 Pro 17.7
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: