-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Experiment: Scan QR to Pay #15384
Draft
staskus
wants to merge
12
commits into
trunk
Choose a base branch
from
task/pos-experiment-with-scan-qr
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collecting scan payment under-the-hood is observing order for .processing status to be set: 1. Set payment status to pending 2. Observe order status changes
Generated by 🚫 Danger |
|
c4bb087
to
b8c8c1f
Compare
A branch with observing push notifications experimentation https://github.com/woocommerce/woocommerce-ios/compare/task/pos-experiment-with-scan-qr...task/pos-experiment-with-scan-qr-with-notification?expand=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: p91TBi-d5g-p2#comment-14097
Description
Experimenting with the idea of showing Scan QR to Pay to selective merchants when card reader payment is not available.
Solution
PointOfSaleScanToPayView
, reusing logic from existingScanToPayView
of showing QR codecollectScanPayment
inPointOfSaleOrderController
which sets the order topending
and observes forprocessing
status every 5 seconds.collectScanPayment
completes, or cancels the task if the screen is closed.scan
payment option is available.The most questionable part of the solution is calling
retrieveOrder
every 5 seconds while the QR code is presented. However, it may be acceptable for an experimental feature that may be used only by a couple of merchants. We could rethink it if we decided to expland.Further Improvements to consider
auto_draft
To make the solution more reliable, we need to reset the order state to auto_draft when going back to edit an order. This makes the payment page unavailable until we open the payment view again and stops customers from paying while the order is still being edited.
Customer address
Context: pdfdoF-6K9-p2
Steps to reproduce
Before testing: Set
defaultValue: treu
forisRemoteFeatureFlagEnabled(.pointOfSale
inPOSEligibilityChecker
(line 104)Testing information
Screenshots
Scan.to.Pay.Flow.mov
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: