-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Order Editing] Show exit confirmation for unsynced changes in a split view #15394
[Order Editing] Show exit confirmation for unsynced changes in a split view #15394
Conversation
In a single-view layout: Editing can always be dismissed because changes are committed instantly. In a split-view layout: Editing can be dismissed when there aren't product changes pending to recalculate. We also need to delete order when discarding changing during the creation flow.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks for this improvement.
Note that it doesn't totally finish fixing the issue though...
If you prevent the deletion, making an edit, tapping cancel, then continuing with the edit instead of discarding it breaks the Recalculate button (and I have no idea why...)
Repro is
- Tap edit
- Select another product
- Tap cancel
- Tap in the header area to dismiss the alert and stay on the order. (Using the header avoids accidentally selecting another product, which prevents repro.)
- Tap recalculate – observe nothing happens.
I still think this should be merged, you can work around the issue by changing selection again.
This was fixed in another PR - #15392 since it was also reported in a separate issue. Sorry for not connecting them both in the description! |
…edit-in-split-view-with-unsynced-changes-doesnt-request-confirmation
…edit-in-split-view-with-unsynced-changes-doesnt-request-confirmation
Closes: #14962
Description
Canceling an order edit in split view with unsynced changes doesn't request confirmation.
Solution
false
fromcanBeDismissed
when the order is in a split-view and there are unsynced changes.editing
flowSteps to reproduce
On iPad
Unsynced changes
Synced changes
Testing information
Screenshots
Simulator.Screen.Recording.-.iPad.Air.11-inch.M2.-.2025-03-21.at.14.05.29.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: